Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker registry error on Nexus and coding.net Registry #189

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

sampsonye
Copy link
Collaborator

Which changes (Bug/Feature):

Fixes #188

Special notes for reviewers:

使用strings.EqualFold进行忽略大小写的比较
使用strings.index来进行字符串判断,防止截取意外的“=”

@sampsonye sampsonye requested a review from colynn October 13, 2022 10:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #189 (36bb47e) into master (c14ef35) will decrease coverage by 7.05%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   22.36%   15.31%   -7.06%     
==========================================
  Files           8       11       +3     
  Lines         304      640     +336     
==========================================
+ Hits           68       98      +30     
- Misses        234      531     +297     
- Partials        2       11       +9     
Impacted Files Coverage Δ
internal/core/settings/registryhub.go 61.22% <77.77%> (ø)
internal/core/settings/settings.go 0.00% <0.00%> (ø)
internal/core/settings/compile_env.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@colynn colynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

internal/core/settings/registryhub.go Show resolved Hide resolved
@sampsonye sampsonye requested a review from colynn October 16, 2022 08:53
Copy link
Member

@colynn colynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np

@colynn colynn merged commit 52eb10d into go-atomci:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nexus 和 Coding.net Registry 不支持的bug
3 participants