This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Update Design For Concurrency! #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the package much easier to import and use. There should be no functional changes in this commit.
It is pretty annoying that a long running command hangs the whole bot. Now commands will be executed on a launched goroutine! Yay! All objects passed into MessageReceived are generated at the call site, so there can be no concurrency issues there. We can later look into making the others concurrent, but for now I just want Slack to work this way.
This reverts commit 4a9a8ca. I really don't understand go package layout. Sorry.
This will be a passive command that can return multiple messages.
This should make it much easier to have many go routines sending messages back to the chat service at the same time, but streamlining them through a channel. I had to add a way to skip the async sending in tests because otherwise I would likely end up having to add sleeps all over the place.
houndci-bot
reviewed
Mar 3, 2018
bot.go
Outdated
| } | ||
| } | ||
|
|
||
| func (b *Bot) Close() { |
There was a problem hiding this comment.
exported method Bot.Close should have comment or be unexported
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a little annoyed that the current bot can only do one thing at a time. So I did some restructuring around how messages are sent back to the underlying chat layer to make sure that concurrency in the bot cannot expose race conditions within the chat layer message sending logic.
While doing so, after reading issue #69 , I decided that a passive version of the V3 command was in order.
So what do you think?