This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Add suport for parsing unicode characters #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioxgn
reviewed
Oct 6, 2018
.circleci/config.yml
Outdated
| @@ -9,5 +9,5 @@ jobs: | |||
| steps: | |||
| - checkout | |||
| - run: go test -v -cover -race -coverprofile=coverage.out | |||
| - run: go get github.com/mattn/goveralls | |||
| - run: go get github.com/mattn/goveralls github.com/mozillazg/go-unidecode | |||
There was a problem hiding this comment.
@1uka this is unnecessary, this project uses go modules. Could you please update the dependencies? Basically you need to use Go 1.11, set GO111MODULE=on and run go get github.com/mozillazg/go-unidecode inside this project directory. It will download the dependency and update the go.mod file.
| @@ -35,7 +36,7 @@ func parse(s string, channel *ChannelData, user *User) (*Cmd, error) { | |||
|
|
|||
| // get the command | |||
| pieces := strings.SplitN(c.Message, " ", 2) | |||
| c.Command = strings.ToLower(pieces[0]) | |||
| c.Command = strings.ToLower(unidecode.Unidecode(pieces[0])) | |||
There was a problem hiding this comment.
Very nice, but can you update the tests please?
|
Hey, will do it as soon as I get home. Sorry for the inconvenience 😊 |
@1uka no problem, thanks for contributing 🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part 2 of #84 .