feat(mux): support http.Request.PathValue in Go 1.22 #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelofallars
changed the title
|
thanks again @angelofallars :) |
|
@pkieltyka You're welcome! :) |
This was referenced Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #873
Adds support for getting path values with
http.Request.PathValue.In Go versions earlier than 1.22 that don't have that method this shouldn't break them due to conditional compilation.
http.Request.PathValuewill act as an alias forchi.URLParam.The only syntax in common with 1.22 pattern matching seems to be single-segment matches like
/b/{bucket}. Other 1.22 features like remaining segment matches (/files/{path...}) and matching trailing slashes (/exact/match/{$}) are not yet supported. Since they are more complicated and overlap with already-existing Chi functionality, they should be addressed in a separate discussion/PR.