Allowed customize SysProcAttr

[wenerme]

e.g. windows need to set HideWindow

func hideWindow(cmd *exec.Cmd) {
	cmd.SysProcAttr.HideWindow = true
}

maybe cmd can accept option like this

type CmdOptions func(c *exec.Cmd)

[cgx027]

It's a good idea to me. I do want to setup the cmd.SysProcAttr.Credential so that I can run commands under another user.

cmd.SysProcAttr.Credential = &syscall.Credential{Uid: uid, Gid: gid}

Refer to https://stackoverflow.com/a/21706757/14833782

[wenerme]

currently using this fork #54

[daniel-nichter]

Re #54: do you just wanted to set SysProcAttr, or do you want a more general-purpose callback like feature (like in that PR)?

[wenerme]

I prefer the general-purpose callback, like use this if you know what you are doing.

[cgx027]

Thanks @daniel-nichter for looking into this. For my user case, both will work fine. I would vote for the general-purpose callback although(as in #54 ) as it will give people a lot more flexibility on using this cool tool.

[daniel-nichter]

@wenerme @Callisto13 et al. I merged PR #54 but reworked in PR #75. Here's why...

Cmd.Options is too close to the Options struct. And this latter is where I'm trying to move options so that Cmd doesn't become overloaded with optional fields. So Options.SetCmd is the better design, but it means you need to specify the callbacks like the test:

	p := cmd.NewCmdOptions(
		cmd.Options{
			SetCmd: []func(cmd *exec.Cmd){
				func(cmd *exec.Cmd) { handled = true },
			},
		},
		"/bin/ls",
	)

If that doesn't work, then I could add Cmd.SetCmd, too, which combines with any Options.SetCmd. Reason being: looking ahead, I'm thinking that v2 of this pkg move all things to Options, so Cmd.SetCmd would be a deprecated featured for the start.

[wenerme]

lgtm, but SetCmd feels strange, more like BeforeExec or something, like hook

[daniel-nichter]

Yeah, the same occurred to me and I wrote it as BeforeExec at one point. Although its original intent was to set/modify the underlying os/exec.Exec, its actual function is a generic before-exec callback/hook. Will think on it, and see if others have ideas, before the v1.4 release (where this will appear officially).

[daniel-nichter]

Renamed to BeforeExec and released as v1.4.0.