Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a better panic message when no jobs in scheduler and start blocking called #501

Merged
merged 1 commit into from
May 30, 2023

Conversation

JohnRoesler
Copy link
Contributor

What does this do?

the code would panic already. in this case we'll pre-empt it and panic with a useful message so the caller knows why

Which issue(s) does this PR fix/relate to?

resolves #500

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

@JohnRoesler JohnRoesler merged commit b035fe3 into main May 30, 2023
@JohnRoesler JohnRoesler deleted the better-panic-message branch May 30, 2023 16:40
JohnRoesler added a commit that referenced this pull request May 30, 2023
JohnRoesler added a commit that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Scheduler panics with unhelpful message if StartBlocking is called with zero jobs in the scheduler
1 participant