Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpNoBody: also warn on using "nil" instead of "http.NoBody" on (net/http/httptest).NewRequest #1344

Closed
leonklingele opened this issue May 17, 2023 · 3 comments
Closed

httpNoBody: also warn on using "nil" instead of "http.NoBody" on (net/http/httptest).NewRequest #1344

leonklingele opened this issue May 17, 2023 · 3 comments
Labels
checker stabilization Checker proposed for stabilization

Comments

@leonklingele
Copy link
Contributor

Currently, no warning is issued when using nil instead of http.NoBody as a third argument to (net/http/httptest).NewRequest.
@cristaloleg cristaloleg added the checker stabilization Checker proposed for stabilization label May 18, 2023
@cristaloleg
Copy link
Member

Nice catch, feel free to make a PR 😉

leonklingele added a commit to leonklingele/go-critic that referenced this issue May 18, 2023
@leonklingele
checkers(httpNoBody): also warn on using "nil" instead of "http.NoBod…
186117b 
…y" on (net/http/httptest).NewRequest

Implements go-critic#1344.
@leonklingele leonklingele mentioned this issue May 18, 2023
Merged
leonklingele added a commit to leonklingele/go-critic that referenced this issue May 18, 2023
@leonklingele
checkers(httpNoBody): also warn on using "nil" instead of "http.NoBod…
c1e3152 
…y" on (net/http/httptest).NewRequest

Implements go-critic#1344.
@leonklingele
Copy link
Contributor Author

@cristaloleg updated, ptal! :)

leonklingele added a commit to leonklingele/go-critic that referenced this issue May 19, 2023
@leonklingele
checkers(httpNoBody): also warn on using "nil" instead of "http.NoBod…
e8e8018 
…y" on (net/http/httptest).NewRequest

Implements go-critic#1344.
@leonklingele
Copy link
Contributor Author

Implemented with d97daec.

lasiar pushed a commit to lasiar/go-critic that referenced this issue Sep 22, 2023
checkers/commentedOutCode: add minimum length of comment parameter.
1c00fda 
Implements go-critic#1344.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
checker stabilization Checker proposed for stabilization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cristaloleg @leonklingele