Wip/obbardc/action-image-partition-label-partlabel-type #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
force-pushed
the
wip/obbardc/action-image-partition-label-partlabel-type
branch
from
4dc7cc0
to
b306bf9
Compare
sjoerdsimons
requested changes
Jun 25, 2020
Debos currently sets the GPT partition label to the `Name` property of the Partition and does not allow the GPT partition label to be set from the recipe. In some situations setting the GPT partition label is required, so add the property `PartLabel` to the Partition and set the GPT partition label to the value of that property. By default, the `PartLabel` property is set to the `Name` property of the Partition to not break backwards compatibility. Resolves: go-debos#202 Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
Debos currently sets the partition type to filesystem type and does not allow the partition type to be set from the recipe. In some situations setting the partition type is required, so add the property `PartType` to the Partition and set the partition type to the value of that property. If the `PartType` property is unset, the original partition type is retained thus not breaking backwards compatibility. For msdos, the partition type should be hexadecimal and 2-characters long. For gpt, the partition GUID should be in GUID format and 36-characters long. Some examples and further reading is included in the documentation. Resolves: go-debos#98 Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
obbardc
force-pushed
the
wip/obbardc/action-image-partition-label-partlabel-type
branch
from
b306bf9
to
a9de93c
Compare
sjoerdsimons
approved these changes
Aug 14, 2020
obbardc
deleted the
wip/obbardc/action-image-partition-label-partlabel-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting filesystem label, partition label and partition type from the recipe.