pkg/logflags: Display warning when unknown component for --log-output #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekparker
requested changes
Feb 27, 2020
pkg/logflags/logflags.go
Outdated
| // If adding another value, do make sure to | ||
| // update "Help about logging flags" in commands.go. | ||
| default: | ||
| if !unKnownHasPrint { // Just print first unknown component. |
There was a problem hiding this comment.
I don't think we need to have this restriction, I don't mind printing a warning for each unknown log item.
There was a problem hiding this comment.
I have try, it looks ok. I will change and rebase.
pkg/logflags/logflags.go
Outdated
| // update "Help about logging flags" in commands.go. | ||
| default: | ||
| if !unKnownHasPrint { // Just print first unknown component. | ||
| fmt.Fprintf(os.Stderr, "Warning: unknown %q for '--log-output', run 'dlv help log' for usage.\n", logcmd) |
There was a problem hiding this comment.
nit: Warning: unknown log output value %s for ...
There was a problem hiding this comment.
I remove for '--log-output' that the same meaning as log output value , avoid too long one line.
Warning: unknown log output value %q, run 'dlv help log' for usage.
|
Has done and rebase. The second version. |
cgxxv
pushed a commit
to cgxxv/delve
that referenced
this pull request
Mar 25, 2022
abner-chenc
pushed a commit
to loongson/delve
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.