cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting client #3632

fatanugraha · 2024-01-15T17:58:45Z

Print out a message and stack trace to the stderr when we hit a breakpoint and the client that sends the continue command has disconnected.

Fixes #3469

aarzilli

I still think that needing this option is a strong symptom that there is something very wrong with your development environment. In the context of running something locally during development you would want the program to stop at a panic to examine why the panic happened.
In the context of running the program in production having a debugger attached to it constantly is a security risk.

derekparker · 2024-01-23T23:53:17Z

I'm also inclined to agree with @aarzilli, however I am familiar with the workflow described in the associated issue, and in that context I could see the benefit to the actual crash being apparent and not silenced by Delve by virtue of waiting on user input to produce the panic.

My initial feedback is I am against wholesale deletion of these breakpoints, I think it would be better to actually disable them, so they can be re-enabled later without having to know the specifics of the runtime.

aarzilli · 2024-01-24T06:26:09Z

We could also print something if we stop at a breakpoint while there isn't a connected client.

derekparker · 2024-01-24T16:19:42Z

We could also print something if we stop at a breakpoint while there isn't a connected client.

That's good too. Might even be nice to print the traceback and panic message automatically when hitting the panic breakpoints anyways, to be honest.

fatanugraha · 2024-01-25T13:19:33Z

I still think that needing this option is a strong symptom that there is something very wrong with your development environment.

I agree with you. This option is needed in our orgs because not everyone are familiar with the debugger and we want to have a setup that is practical and convenient for everyone.

My initial feedback is I am against wholesale deletion of these breakpoints, I think it would be better to actually disable them, so they can be re-enabled later without having to know the specifics of the runtime.

I tried this one actually, instead of deleting them I tried to toggling off those breakpoints, but it's not possible to do that through the API because we will reject any request that has - in it. If we're okay with changing the API behaviour I can adjust the MR to do this instead.

That's good too. Might even be nice to print the traceback and panic message automatically when hitting the panic breakpoints anyways, to be honest.

Ideally yeah this is what I'm looking for, but it seems to be a bit tricky to pull off. Let me see if i can find a way to do this.

aarzilli · 2024-01-25T15:26:40Z

Ideally yeah this is what I'm looking for, but it seems to be a bit tricky to pull off. Let me see if i can find a way to do this.

One way to do it would be like this:

There's a function in service/rpccommon/server.go called serveJSONCodec, that's the function that serves requests from a client. You can have a boolean there that you set to false when that function exits and check it in (*RPCCallback).Return.
This boolean needs to be protected with a mutex so you could copy the syncflag type in service/dap/server.go.
Have (*RPCCallback).Return return false if the client has quit and then print something in (*RPCServer).Command in service/rpc2/server.go

fatanugraha · 2024-01-26T04:37:18Z

One way to do it would be like this:

oh ya i have implemented this in this PR but in a different fashion.

Might even be nice to print the traceback and panic message automatically when hitting the panic breakpoints anyways, to be honest.

Initially im thinking to move the unhandled panic breakpoint to somewhere after we print out the message but it's going to be a bit tricky to make it sure it works for older (and future) go versions so I'm going with implementing this on the server side. Hope that's acceptable.

aarzilli

(this was a leftover comment)

_fixtures/fatalthrow.go

service/rpc2/server.go

derekparker · 2024-02-22T19:35:56Z

Hey @fatanugraha there has been no update on this PR in a month, are you still planning to work on this?

fatanugraha · 2024-02-23T22:22:32Z

Hi @derekparker I have plans to pick this up again in 1-2 weeks from now, but if anyone else wants to work on this issue I'm also okay with that. Sorry for the delay :(

derekparker · 2024-02-23T22:34:13Z

Hi @derekparker I have plans to pick this up again in 1-2 weeks from now, but if anyone else wants to work on this issue I'm also okay with that. Sorry for the delay :(

No worries, and no rush! Just wanted to check in.

service/rpc2/server.go

TomK · 2024-04-05T12:01:52Z

@fatanugraha would you like some additional hands on this?
I'm happy to make the changes suggested by @aarzilli

fatanugraha · 2024-04-07T07:49:42Z

Hey folks, sorry for the bad delays. Here's how it looks right now if we hit a breakpoint (screenshot below is when we hit the panic/fatal bp) but the client that sends the continue gone already

cmd/dlv/dlv_test.go

service/rpc2/server.go

service/rpccommon/server.go

service/debugger/debugger.go

service/dap/server.go

service/debugger/debugger.go

fatanugraha · 2024-05-30T17:31:41Z

Sorry folks for the long delay, life got in the way 😅

aarzilli

Overall this is good, except for a couple of changes that may have been caused by a merge conflict. Also could you remove all the extra newlines that you have added at various points.

service/dap/server.go

service/debugger/debugger.go

aarzilli

LGTM, thank you.

TomK · 2024-06-01T10:16:42Z

Great work @fatanugraha 🙏

TomK · 2024-06-06T17:02:14Z

@aarzilli sorry to tag you, but what's required now to get this merged in?

aarzilli · 2024-06-06T17:19:57Z

Review by Derek.

derekparker

LGTM

TomK · 2024-06-14T17:40:18Z

service/debugger/debugger.go

+
+	bp := currentThread.Breakpoint
+	if bp == nil {
+		fmt.Fprintln(os.Stderr, "bp", bp)


i don't think this log line is necessary. When attaching a debugger to a long running process we get bp <nil> logged out. It'll never be more useful than that.

@fatanugraha

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-delve/delve](https://togithub.com/go-delve/delve) | `v1.22.1` -> `v1.23.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-delve%2fdelve/v1.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-delve%2fdelve/v1.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-delve%2fdelve/v1.22.1/v1.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-delve%2fdelve/v1.22.1/v1.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-delve/delve (github.com/go-delve/delve)</summary> ### [`v1.23.0`](https://togithub.com/go-delve/delve/releases/tag/v1.23.0) [Compare Source](https://togithub.com/go-delve/delve/compare/v1.22.1...v1.23.0) #### What's Changed - dwarfbuilder: fix makeAbbrevTable by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3665 - \*: misc fixes for go1.23 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3663 - elfwriter: add WriteSectionHeaders by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3666 - Upgrade github.com/google/go-dap to v0.12.0 by [@suzmue](https://togithub.com/suzmue) in [go-delve/delve#3673 - pkg/terminal,pkg/proc: Implement next-instruction by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3671 - pkg/terminal: print breakpoint number on stop by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3675 - proc/evalop: remove no longer needed Go 1.17 files by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3676 - Cirrus-CI: update to FreeBSD 13.3 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3679 - dwarf/loclist: remove impossible condition by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3677 - proc: catch panics when reading debug info for stripped executables by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3678 - proc,go.mod: update x/sys remove KeepAlive calls by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3680 - pkg/proc: defend better against missing DWARF by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3695 - proc: support reading captured variables of closures by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3682 - pkg/terminal: allow postfix if for breakpoint conds by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3693 - proc: change 'step' command so that it steps through go statements by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3686 - cmd/dlv: add shell (non-)completions to flags taking args by [@scop](https://togithub.com/scop) in [go-delve/delve#3696 - cmd/dlv: fix panic on connect fail by [@scop](https://togithub.com/scop) in [go-delve/delve#3698 - tests: fix tests on Go 1.23 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3697 - pkg/terminal: clear erroneous name setting on postfix if by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3702 - pkg/terminal: remove duplicated word by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3707 - cmd/dlv: improve positional argument completion by [@scop](https://togithub.com/scop) in [go-delve/delve#3699 - proc: generalize escapeCheck and allocString by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3687 - rr: fix gdb parsing by [@howardjohn](https://togithub.com/howardjohn) in [go-delve/delve#3705 - Add function name even in return trace by [@archanaravindar](https://togithub.com/archanaravindar) in [go-delve/delve#3712 - pkg/proc: fix watchpoints on macos by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3703 - \_scripts: upgrade to python3 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3716 - pkg/proc/gdbserial: optimize gdbwire backend by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3715 - gdbserial: update path of lldb protocol extension documentation by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3727 - gdbserial: fixes for rr 5.7.0 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3718 - pkg/terminal: remove deprecated starlark global options by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3722 - \*: remove redundant lines at the start/end of block by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3730 - Update actions/checkout to v4 by [@abbasudo](https://togithub.com/abbasudo) in [go-delve/delve#3731 - proc/gdbserial: add environment variables to configure rr invocation by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3726 - proc: initial stepping with range-over-func support by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3736 - cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting client by [@fatanugraha](https://togithub.com/fatanugraha) in [go-delve/delve#3632 - Support to add a new suboption --follow-calls to trace subcommand by [@archanaravindar](https://togithub.com/archanaravindar) in [go-delve/delve#3594 - proc: fix bug with stack watchpoints going out of scope by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3742 - proc: fix TestRangeOverFuncNext by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3740 - proc: refactor identifier evaluation for range-over-func support by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3738 - service: print better message for unattended stops by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3747 - pkg/astutil,pkg/elfwriter: fix package doc by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3753 - \*: replace fmt.Errorf with errors.New by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3752 - proc: initial support for expressions with range-over-func by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3750 - pkg/terminal: do not use deprecated strings.Title by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3756 - all: fix typos in CHANGELOG, comments and package name by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3757 - refactor: move loadModuleData from runtimeTypeToDIE and expose the apis by [@jayantxie](https://togithub.com/jayantxie) in [go-delve/delve#3741 - pkg/proc,service/debugger: fix debuginfod-find source by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3762 - fix: mem cache out of range panic caused by overflow by [@jayantxie](https://togithub.com/jayantxie) in [go-delve/delve#3761 - proc: support stepping through range-over-func statements with inlining by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3755 - service/debugger: evaluate breakpoint vars on g-less threads by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3759 - fix: LoadAbstractOriginAndSpecification infinite loop caused by abstr… by [@zdyj3170101136](https://togithub.com/zdyj3170101136) in [go-delve/delve#3767 - \*: remove redundant lines at the start/end of block by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3773 - pkg/proc: fix 404 links and change to https by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3775 - go.mod: update gopkg.in/yaml to v3 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3776 - pkg/terminal: add missing file.Close() call by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3770 - pkg: refactor to .WriteString() instead of .Write(\[]byte()) by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3769 - pkg/dwarf/line: use t.Logf instead of fmt.Printf in tests by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3772 - proc: use .closureptr for stepping through range-over-func statements by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3763 - service/rpc1: add Go Reference doc by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3779 - \*: replace old golang.org links with new go.dev by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3774 - proc: fix bug with range-over-func stepping by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3778 - goversion: add 1.23 to supported versions, update test matrix by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3780 - teamcity: fix typo in configuration by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3783 - \*: release version 1.23.0 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3782 #### New Contributors - [@scop](https://togithub.com/scop) made their first contribution in [go-delve/delve#3696 - [@howardjohn](https://togithub.com/howardjohn) made their first contribution in [go-delve/delve#3705 - [@abbasudo](https://togithub.com/abbasudo) made their first contribution in [go-delve/delve#3731 - [@fatanugraha](https://togithub.com/fatanugraha) made their first contribution in [go-delve/delve#3632 - [@jayantxie](https://togithub.com/jayantxie) made their first contribution in [go-delve/delve#3741 - [@zdyj3170101136](https://togithub.com/zdyj3170101136) made their first contribution in [go-delve/delve#3767 **Full Changelog**: https://github.com/go-delve/delve/blob/master/CHANGELOG.md#1230-2024-07-16 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger).  Signed-off-by: Mend Renovate <bot@renovateapp.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-delve/delve](https://togithub.com/go-delve/delve) | `v1.22.1` -> `v1.23.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-delve%2fdelve/v1.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-delve%2fdelve/v1.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-delve%2fdelve/v1.22.1/v1.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-delve%2fdelve/v1.22.1/v1.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-delve/delve (github.com/go-delve/delve)</summary> ### [`v1.23.0`](https://togithub.com/go-delve/delve/releases/tag/v1.23.0) [Compare Source](https://togithub.com/go-delve/delve/compare/v1.22.1...v1.23.0) #### What's Changed - dwarfbuilder: fix makeAbbrevTable by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3665 - \*: misc fixes for go1.23 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3663 - elfwriter: add WriteSectionHeaders by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3666 - Upgrade github.com/google/go-dap to v0.12.0 by [@suzmue](https://togithub.com/suzmue) in [go-delve/delve#3673 - pkg/terminal,pkg/proc: Implement next-instruction by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3671 - pkg/terminal: print breakpoint number on stop by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3675 - proc/evalop: remove no longer needed Go 1.17 files by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3676 - Cirrus-CI: update to FreeBSD 13.3 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3679 - dwarf/loclist: remove impossible condition by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3677 - proc: catch panics when reading debug info for stripped executables by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3678 - proc,go.mod: update x/sys remove KeepAlive calls by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3680 - pkg/proc: defend better against missing DWARF by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3695 - proc: support reading captured variables of closures by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3682 - pkg/terminal: allow postfix if for breakpoint conds by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3693 - proc: change 'step' command so that it steps through go statements by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3686 - cmd/dlv: add shell (non-)completions to flags taking args by [@scop](https://togithub.com/scop) in [go-delve/delve#3696 - cmd/dlv: fix panic on connect fail by [@scop](https://togithub.com/scop) in [go-delve/delve#3698 - tests: fix tests on Go 1.23 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3697 - pkg/terminal: clear erroneous name setting on postfix if by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3702 - pkg/terminal: remove duplicated word by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3707 - cmd/dlv: improve positional argument completion by [@scop](https://togithub.com/scop) in [go-delve/delve#3699 - proc: generalize escapeCheck and allocString by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3687 - rr: fix gdb parsing by [@howardjohn](https://togithub.com/howardjohn) in [go-delve/delve#3705 - Add function name even in return trace by [@archanaravindar](https://togithub.com/archanaravindar) in [go-delve/delve#3712 - pkg/proc: fix watchpoints on macos by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3703 - \_scripts: upgrade to python3 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3716 - pkg/proc/gdbserial: optimize gdbwire backend by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3715 - gdbserial: update path of lldb protocol extension documentation by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3727 - gdbserial: fixes for rr 5.7.0 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3718 - pkg/terminal: remove deprecated starlark global options by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3722 - \*: remove redundant lines at the start/end of block by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3730 - Update actions/checkout to v4 by [@abbasudo](https://togithub.com/abbasudo) in [go-delve/delve#3731 - proc/gdbserial: add environment variables to configure rr invocation by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3726 - proc: initial stepping with range-over-func support by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3736 - cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting client by [@fatanugraha](https://togithub.com/fatanugraha) in [go-delve/delve#3632 - Support to add a new suboption --follow-calls to trace subcommand by [@archanaravindar](https://togithub.com/archanaravindar) in [go-delve/delve#3594 - proc: fix bug with stack watchpoints going out of scope by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3742 - proc: fix TestRangeOverFuncNext by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3740 - proc: refactor identifier evaluation for range-over-func support by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3738 - service: print better message for unattended stops by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3747 - pkg/astutil,pkg/elfwriter: fix package doc by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3753 - \*: replace fmt.Errorf with errors.New by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3752 - proc: initial support for expressions with range-over-func by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3750 - pkg/terminal: do not use deprecated strings.Title by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3756 - all: fix typos in CHANGELOG, comments and package name by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3757 - refactor: move loadModuleData from runtimeTypeToDIE and expose the apis by [@jayantxie](https://togithub.com/jayantxie) in [go-delve/delve#3741 - pkg/proc,service/debugger: fix debuginfod-find source by [@derekparker](https://togithub.com/derekparker) in [go-delve/delve#3762 - fix: mem cache out of range panic caused by overflow by [@jayantxie](https://togithub.com/jayantxie) in [go-delve/delve#3761 - proc: support stepping through range-over-func statements with inlining by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3755 - service/debugger: evaluate breakpoint vars on g-less threads by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3759 - fix: LoadAbstractOriginAndSpecification infinite loop caused by abstr… by [@zdyj3170101136](https://togithub.com/zdyj3170101136) in [go-delve/delve#3767 - \*: remove redundant lines at the start/end of block by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3773 - pkg/proc: fix 404 links and change to https by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3775 - go.mod: update gopkg.in/yaml to v3 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3776 - pkg/terminal: add missing file.Close() call by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3770 - pkg: refactor to .WriteString() instead of .Write(\[]byte()) by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3769 - pkg/dwarf/line: use t.Logf instead of fmt.Printf in tests by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3772 - proc: use .closureptr for stepping through range-over-func statements by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3763 - service/rpc1: add Go Reference doc by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3779 - \*: replace old golang.org links with new go.dev by [@alexandear](https://togithub.com/alexandear) in [go-delve/delve#3774 - proc: fix bug with range-over-func stepping by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3778 - goversion: add 1.23 to supported versions, update test matrix by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3780 - teamcity: fix typo in configuration by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3783 - \*: release version 1.23.0 by [@aarzilli](https://togithub.com/aarzilli) in [go-delve/delve#3782 #### New Contributors - [@scop](https://togithub.com/scop) made their first contribution in [go-delve/delve#3696 - [@howardjohn](https://togithub.com/howardjohn) made their first contribution in [go-delve/delve#3705 - [@abbasudo](https://togithub.com/abbasudo) made their first contribution in [go-delve/delve#3731 - [@fatanugraha](https://togithub.com/fatanugraha) made their first contribution in [go-delve/delve#3632 - [@jayantxie](https://togithub.com/jayantxie) made their first contribution in [go-delve/delve#3741 - [@zdyj3170101136](https://togithub.com/zdyj3170101136) made their first contribution in [go-delve/delve#3767 **Full Changelog**: https://github.com/go-delve/delve/blob/master/CHANGELOG.md#1230-2024-07-16 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger).  Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Jared Tan <jian.tan@daocloud.io>

fatanugraha force-pushed the support-disable-panic-catcher branch 2 times, most recently from c12a582 to 66a3316 Compare January 15, 2024 18:04

aarzilli reviewed Jan 15, 2024

View reviewed changes

fatanugraha force-pushed the support-disable-panic-catcher branch from 66a3316 to c29cb69 Compare January 25, 2024 19:39

fatanugraha changed the title ~~cmd/dlv: add --disable-break-on-panic to disable panic handler breakpoint auto creation~~ cmd/dlv: print out message for multi accept mode on panic/fatalthrow Jan 25, 2024

aarzilli reviewed Jan 28, 2024

View reviewed changes

_fixtures/fatalthrow.go Outdated Show resolved Hide resolved

service/rpc2/server.go Outdated Show resolved Hide resolved

service/rpc2/server.go Outdated Show resolved Hide resolved

service/rpc2/server.go Outdated Show resolved Hide resolved

TomK mentioned this pull request Apr 5, 2024

feature request: option to disable unrecovered panic breakpoint #3653

Closed

TomK reviewed Apr 5, 2024

View reviewed changes

service/rpc2/server.go Outdated Show resolved Hide resolved

fatanugraha force-pushed the support-disable-panic-catcher branch from cf2069e to c9531a9 Compare April 7, 2024 07:48

fatanugraha changed the title ~~cmd/dlv: print out message for multi accept mode on panic/fatalthrow~~ cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting clients Apr 7, 2024

fatanugraha changed the title ~~cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting clients~~ cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting client Apr 7, 2024

aarzilli reviewed Apr 8, 2024

View reviewed changes

cmd/dlv/dlv_test.go Outdated Show resolved Hide resolved

service/rpc2/server.go Outdated Show resolved Hide resolved

fatanugraha force-pushed the support-disable-panic-catcher branch from ac5dd6c to 593758a Compare April 17, 2024 16:24

derekparker requested changes Apr 19, 2024

View reviewed changes

service/rpccommon/server.go Outdated Show resolved Hide resolved

service/debugger/debugger.go Outdated Show resolved Hide resolved

service/dap/server.go Outdated Show resolved Hide resolved

aarzilli reviewed Apr 24, 2024

View reviewed changes

service/debugger/debugger.go Outdated Show resolved Hide resolved

fatanugraha force-pushed the support-disable-panic-catcher branch from 9a37b4b to ae15db6 Compare May 30, 2024 17:34

fatanugraha added 2 commits May 31, 2024 01:35

Print out message and dump stack on pause

fe3f215

Fix test

fc92b7a

fatanugraha added 5 commits May 31, 2024 01:35

Move the logic to debugger layer

30e58c9

Remove unused fields

99b9151

Do not use defer to get state

5df5f23

move channel to connection

c37e9ff

remove lock on isClosed

6667b65

fatanugraha force-pushed the support-disable-panic-catcher branch from ae15db6 to 6667b65 Compare May 30, 2024 17:35

Use mutex

2b6cff9

aarzilli reviewed May 31, 2024

View reviewed changes

service/dap/server.go Outdated Show resolved Hide resolved

service/debugger/debugger.go Outdated Show resolved Hide resolved

Remove unwanted changes

aedba9b

aarzilli approved these changes Jun 1, 2024

View reviewed changes

fatanugraha requested a review from derekparker June 10, 2024 08:49

derekparker approved these changes Jun 12, 2024

View reviewed changes

derekparker merged commit 15a9f9d into go-delve:master Jun 12, 2024
2 checks passed

TomK reviewed Jun 14, 2024

View reviewed changes

BrewTestBot mentioned this pull request Jul 16, 2024

delve 1.23.0 Homebrew/homebrew-core#177542

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting client #3632

cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting client #3632

fatanugraha commented Jan 15, 2024 •

edited

Loading

aarzilli left a comment

derekparker commented Jan 23, 2024

aarzilli commented Jan 24, 2024

derekparker commented Jan 24, 2024

fatanugraha commented Jan 25, 2024

aarzilli commented Jan 25, 2024

fatanugraha commented Jan 26, 2024

aarzilli left a comment •

edited

Loading

derekparker commented Feb 22, 2024

fatanugraha commented Feb 23, 2024

derekparker commented Feb 23, 2024

TomK commented Apr 5, 2024

fatanugraha commented Apr 7, 2024 •

edited

Loading

fatanugraha commented May 30, 2024

aarzilli left a comment

aarzilli left a comment

TomK commented Jun 1, 2024

TomK commented Jun 6, 2024

aarzilli commented Jun 6, 2024

derekparker left a comment

TomK Jun 14, 2024

TomK Jun 14, 2024

cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting client #3632

cmd/dlv: print out message with stack trace when breakpoint is hit but has no waiting client #3632

Conversation

fatanugraha commented Jan 15, 2024 • edited Loading

aarzilli left a comment

Choose a reason for hiding this comment

derekparker commented Jan 23, 2024

aarzilli commented Jan 24, 2024

derekparker commented Jan 24, 2024

fatanugraha commented Jan 25, 2024

aarzilli commented Jan 25, 2024

fatanugraha commented Jan 26, 2024

aarzilli left a comment • edited Loading

Choose a reason for hiding this comment

derekparker commented Feb 22, 2024

fatanugraha commented Feb 23, 2024

derekparker commented Feb 23, 2024

TomK commented Apr 5, 2024

fatanugraha commented Apr 7, 2024 • edited Loading

fatanugraha commented May 30, 2024

aarzilli left a comment

Choose a reason for hiding this comment

aarzilli left a comment

Choose a reason for hiding this comment

TomK commented Jun 1, 2024

TomK commented Jun 6, 2024

aarzilli commented Jun 6, 2024

derekparker left a comment

Choose a reason for hiding this comment

TomK Jun 14, 2024

Choose a reason for hiding this comment

TomK Jun 14, 2024

Choose a reason for hiding this comment

fatanugraha commented Jan 15, 2024 •

edited

Loading

aarzilli left a comment •

edited

Loading

fatanugraha commented Apr 7, 2024 •

edited

Loading