New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor incomplete comments of exported functions #183

Merged

chenjiandongx merged 1 commit into go-echarts:master from chutommy:refactor-comments-1

Jun 21, 2021

Contributor

chutommy commented Jun 19, 2021

I refactored and completed some unfinished comments. I mainly followed practices mentioned in Effective Go:

All comments should start with a whitespace.
Comments of exported functions should begin with the name being declared.
Comments should be meaningful or they should be removed.

However, please feel free to edit or make any changes you deem necessary.


          Refactor incomplete comments of exported functions

4441c82

chenjiandongx approved these changes

View reviewed changes

Member

chenjiandongx left a comment

Thanks

chenjiandongx merged commit 8e7e3e1 into go-echarts:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet