Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite skipNumber #12

Merged
merged 11 commits into from
Jan 13, 2022
Merged

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Jan 12, 2022

name             old time/op    new time/op    delta
Valid/Big-12       3.98µs ± 2%    3.93µs ± 2%      ~     (p=0.151 n=10+9)
Valid/Floats-12    16.7µs ± 1%     3.2µs ± 2%   -81.06%  (p=0.000 n=9+9)

name             old speed      new speed      delta
Valid/Big-12      658MB/s ± 2%   666MB/s ± 3%      ~     (p=0.156 n=10+9)
Valid/Floats-12   134MB/s ± 0%   706MB/s ± 2%  +428.11%  (p=0.000 n=9+9)

name             old alloc/op   new alloc/op   delta
Valid/Big-12        0.00B          0.00B           ~     (all equal)
Valid/Floats-12    2.39kB ± 0%    0.00kB       -100.00%  (p=0.000 n=10+10)

name             old allocs/op  new allocs/op  delta
Valid/Big-12         0.00           0.00           ~     (all equal)
Valid/Floats-12       100 ± 0%         0       -100.00%  (p=0.000 n=10+10)

Fix #8

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #12 (29e97c5) into main (4b65b2d) will decrease coverage by 0.24%.
The diff coverage is 97.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   99.89%   99.65%   -0.25%     
==========================================
  Files          29       29              
  Lines        1916     2011      +95     
==========================================
+ Hits         1914     2004      +90     
- Misses          2        6       +4     
- Partials        0        1       +1     
Impacted Files Coverage Δ
dec_skip.go 98.29% <96.94%> (-1.71%) ⬇️
dec_str.go 100.00% <100.00%> (ø)
dec_float.go 98.89% <0.00%> (-1.11%) ⬇️
dec_b64.go 100.00% <0.00%> (ø)
w.go 100.00% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b65b2d...29e97c5. Read the comment docs.

ernado and others added 6 commits January 12, 2022 19:35
name             old time/op    new time/op    delta
Valid/Big-12       3.98µs ± 5%    3.60µs ± 2%   -9.63%  (p=0.000 n=25+24)
Valid/Floats-12    3.23µs ± 4%    2.91µs ± 1%   -9.92%  (p=0.000 n=25+24)

name             old speed      new speed      delta
Valid/Big-12      657MB/s ± 5%   727MB/s ± 2%  +10.61%  (p=0.000 n=25+24)
Valid/Floats-12   720MB/s ± 3%   799MB/s ± 1%  +10.98%  (p=0.000 n=25+24)
@tdakkota tdakkota marked this pull request as ready for review January 13, 2022 11:36
@tdakkota tdakkota merged commit 355fdc6 into go-faster:main Jan 13, 2022
@tdakkota tdakkota deleted the feat/smarter-skip-number branch January 13, 2022 12:46
@tdakkota tdakkota mentioned this pull request Jan 14, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: speedup float skip
2 participants