Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rewrite skipNumber #12

Merged
merged 11 commits into from
Jan 13, 2022
Merged

feat: rewrite skipNumber #12

merged 11 commits into from
Jan 13, 2022

Commits on Jan 12, 2022

  1. test: add more skipNumber tests

    @tdakkota
    tdakkota committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    f751731 View commit details
    Browse the repository at this point in the history

  2. feat: rewrite skipNumber

    @tdakkota
    tdakkota committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    b4b52bf View commit details
    Browse the repository at this point in the history

  3. test: generate more skip cases

    @tdakkota
    tdakkota committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    9a20f0e View commit details
    Browse the repository at this point in the history

  4. test: add floats benchmark

    @tdakkota
    tdakkota committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    1da9437 View commit details
    Browse the repository at this point in the history

  5. test(fuzz): update Valid fuzzer

    @ernado
    ernado committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    510eda1 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. fix: 0e0.0 case in skipNumber

    @tdakkota
    tdakkota committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    176748e View commit details
    Browse the repository at this point in the history

  2. fix: some cases for stream reading

    @tdakkota
    tdakkota committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    5650462 View commit details
    Browse the repository at this point in the history

  3. test: add OneByteReader test

    @tdakkota
    tdakkota committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    fe101be View commit details
    Browse the repository at this point in the history

  4. fix: invalid -00 number skipping

    @tdakkota
    tdakkota committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    efb411f View commit details
    Browse the repository at this point in the history

  5. fix: merge skipNumber sets to reduce cache load 

    name             old time/op    new time/op    delta
Valid/Big-12       3.98µs ± 5%    3.60µs ± 2%   -9.63%  (p=0.000 n=25+24)
Valid/Floats-12    3.23µs ± 4%    2.91µs ± 1%   -9.92%  (p=0.000 n=25+24)

name             old speed      new speed      delta
Valid/Big-12      657MB/s ± 5%   727MB/s ± 2%  +10.61%  (p=0.000 n=25+24)
Valid/Floats-12   720MB/s ± 3%   799MB/s ± 1%  +10.98%  (p=0.000 n=25+24)
    @tdakkota
    tdakkota committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    85c2c59 View commit details
    Browse the repository at this point in the history

  6. fix: check for unescaped char in strSlow

    @tdakkota
    tdakkota committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    29e97c5 View commit details
    Browse the repository at this point in the history