skip unrecognized sections, subsections, and variables #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the behavior to match that of encoding/json, etc., which do
not complain if input data is not fully represented in resulting
struct.
@speter: It seems that it was a conscious design decision to be strict about mapping all input to the struct. Is this a requirement? It actually makes it nearly impossible (AFAICT) to use this to actually parse git config files, which can contain arbitrary top-level sections.
One future improvement could be having gcfg put extraneous unmapped data into a struct field (if present) named
Extra
or tagged withgcfg:",extra"
, or something like that.