Skip to content

Commit

Permalink
Remove jQuery class from the common admin functions (#30137)
Browse files Browse the repository at this point in the history
- Switched from jQuery class functions to plain JavaScript `classList`
- Tested the new authentication source form and the deletion of system
notices. They work as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
  • Loading branch information
yardenshoham and GiteaBot committed Mar 27, 2024
1 parent 1a71dbf commit 1551d73
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions web_src/js/features/admin/common.js
Expand Up @@ -122,7 +122,7 @@ export function initAdminCommon() {
input.removeAttribute('required');
}

$('.binddnrequired').removeClass('required');
document.querySelector('.binddnrequired')?.classList.remove('required');

const authType = this.value;
switch (authType) {
Expand All @@ -131,7 +131,7 @@ export function initAdminCommon() {
for (const input of document.querySelectorAll('.binddnrequired input, .ldap div.required:not(.dldap) input')) {
input.setAttribute('required', 'required');
}
$('.binddnrequired').addClass('required');
document.querySelector('.binddnrequired')?.classList.add('required');
break;
case '3': // SMTP
showElem('.smtp');
Expand Down Expand Up @@ -234,16 +234,15 @@ export function initAdminCommon() {
});
document.getElementById('delete-selection')?.addEventListener('click', async function (e) {
e.preventDefault();
const $this = $(this);
$this.addClass('is-loading disabled');
this.classList.add('is-loading', 'disabled');
const data = new FormData();
$checkboxes.each(function () {
if ($(this).checkbox('is checked')) {
data.append('ids[]', $(this).data('id'));
data.append('ids[]', this.getAttribute('data-id'));
}
});
await POST($this.data('link'), {data});
window.location.href = $this.data('redirect');
await POST(this.getAttribute('data-link'), {data});
window.location.href = this.getAttribute('data-redirect');
});
}
}

0 comments on commit 1551d73

Please sign in to comment.