Skip to content

Commit

Permalink
ui fixes - compare view and archieved repo issues (#7345)
Browse files Browse the repository at this point in the history
* add 'repo archived - comment/pull not possible' message

affects #7304

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* add navbar to compare view

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* remove wrong if else

Signed-off-by: Michael Gnehr <michael@gnehr.de>
  • Loading branch information
Cherrg authored and zeripath committed Jul 8, 2019
1 parent 0622e83 commit 3c3f749
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 7 deletions.
14 changes: 11 additions & 3 deletions templates/repo/diff/compare.tmpl
Expand Up @@ -5,8 +5,12 @@

{{if .PageIsComparePull}}
<h2 class="ui header">
{{.i18n.Tr "repo.pulls.compare_changes"}}
<div class="sub header">{{.i18n.Tr "repo.pulls.compare_changes_desc"}}</div>
{{if not .Repository.IsArchived}}
{{.i18n.Tr "repo.pulls.compare_changes"}}
<div class="sub header">{{.i18n.Tr "repo.pulls.compare_changes_desc"}}</div>
{{ else }}
{{.i18n.Tr "action.compare_commits_general"}}
{{ end }}
</h2>
<div class="ui segment choose branch">
<span class="octicon octicon-git-compare"></span>
Expand Down Expand Up @@ -60,7 +64,11 @@
<div class="ui info message show-form-container">
<button class="ui button green show-form">{{.i18n.Tr "repo.pulls.new"}}</button>
</div>
{{end}}
{{ else }}
<div class="ui warning message">
{{.i18n.Tr "repo.archive.title"}}
</div>
{{ end }}
<div class="pullrequest-form" style="display: none">
{{template "repo/issue/new_form" .}}
</div>
Expand Down
6 changes: 2 additions & 4 deletions templates/repo/header.tmpl
Expand Up @@ -46,7 +46,7 @@
</div><!-- end grid -->
</div><!-- end container -->
{{end}}
{{if not .IsDiffCompare}}

<div class="ui tabs container">
<div class="ui tabular stackable menu navbar">
{{if .Permission.CanRead $.UnitTypeCode}}
Expand Down Expand Up @@ -103,7 +103,5 @@
</div>
</div>
<div class="ui tabs divider"></div>
{{else}}
<div class="ui divider"></div>
{{end}}

</div>
8 changes: 8 additions & 0 deletions templates/repo/issue/view_content.tmpl
Expand Up @@ -107,6 +107,14 @@
</form>
</div>
</div>
{{ else if .Repository.IsArchived }}
<div class="ui warning message">
{{if .Issue.IsPull}}
{{.i18n.Tr "repo.archive.pull.nocomment"}}
{{else}}
{{.i18n.Tr "repo.archive.issue.nocomment"}}
{{end}}
</div>
{{ end }}
{{else}}
{{if .Repository.IsArchived}}
Expand Down

0 comments on commit 3c3f749

Please sign in to comment.