Skip to content

Commit

Permalink
Fix delete SSH key in file
Browse files Browse the repository at this point in the history
  • Loading branch information
unknwon committed Mar 16, 2014
1 parent 8de9517 commit ab747f2
Show file tree
Hide file tree
Showing 6 changed files with 138 additions and 9 deletions.
4 changes: 2 additions & 2 deletions conf/app.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ RUN_USER = lunny

[repository]
ROOT = /Users/%(RUN_USER)s/git/gogs-repositories
LANG_IGNS=Google Go|C|Python
LICENSES=Apache v2 License|GPL v2|BSD (3-Clause) License
LANG_IGNS=Google Go|C|Python|Ruby
LICENSES=Apache v2 License|GPL v2|MIT License|BSD (3-Clause) License

[server]
HTTP_ADDR =
Expand Down
18 changes: 18 additions & 0 deletions conf/gitignore/Ruby
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
*.gem
*.rbc
.bundle
.config
coverage
InstalledFiles
lib/bundler/man
pkg
rdoc
spec/reports
test/tmp
test/version_tmp
tmp

# YARD artifacts
.yardoc
_yardoc
doc/
21 changes: 21 additions & 0 deletions conf/license/MIT License
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
The MIT License (MIT)

Copyright (c) 2014

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
88 changes: 81 additions & 7 deletions models/publickey.go
Original file line number Diff line number Diff line change
@@ -1,21 +1,30 @@
// Copyright 2014 The Gogs Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.

package models

import (
"bufio"
"fmt"
"io"
"os"
"os/exec"
"path/filepath"
"strings"
"sync"
"time"

"github.com/Unknwon/com"
)

var (
sshOpLocker = sync.Mutex{}
//publicKeyRootPath string
sshPath string
appPath string
tmplPublicKey = "### autogenerated by gitgos, DO NOT EDIT\n" +
"command=\"%s serv key-%d\",no-port-forwarding," +
sshPath string
appPath string
// "### autogenerated by gitgos, DO NOT EDIT\n"
tmplPublicKey = "command=\"%s serv key-%d\",no-port-forwarding," +
"no-X11-forwarding,no-agent-forwarding,no-pty %s\n"
)

Expand Down Expand Up @@ -77,9 +86,69 @@ func AddPublicKey(key *PublicKey) error {
return nil
}

func DeletePublicKey(key *PublicKey) error {
_, err := orm.Delete(key)
return err
// DeletePublicKey deletes SSH key information both in database and authorized_keys file.
func DeletePublicKey(key *PublicKey) (err error) {
if _, err = orm.Delete(key); err != nil {
return err
}

sshOpLocker.Lock()
defer sshOpLocker.Unlock()

p := filepath.Join(sshPath, "authorized_keys")
tmpP := filepath.Join(sshPath, "authorized_keys.tmp")
fr, err := os.Open(p)
if err != nil {
return err
}
defer fr.Close()

fw, err := os.Create(tmpP)
if err != nil {
return err
}
defer fw.Close()

buf := bufio.NewReader(fr)
for {
line, errRead := buf.ReadString('\n')
line = strings.TrimSpace(line)

if errRead != nil {
if errRead != io.EOF {
return errRead
}

// Reached end of file, if nothing to read then break,
// otherwise handle the last line.
if len(line) == 0 {
break
}
}

// Found the line and copy rest of file.
if strings.Contains(line, key.Content) {
if _, err = io.Copy(fw, fr); err != nil {
return err
}
break
}

// Still finding the line, copy the line that currently read.
if _, err = fw.WriteString(line + "\n"); err != nil {
return err
}

if errRead == io.EOF {
break
}
}

if err = os.Remove(p); err != nil {
return err
}

return os.Rename(tmpP, p)
}

func ListPublicKey(userId int64) ([]PublicKey, error) {
Expand All @@ -89,11 +158,16 @@ func ListPublicKey(userId int64) ([]PublicKey, error) {
}

func SaveAuthorizedKeyFile(key *PublicKey) error {
sshOpLocker.Lock()
defer sshOpLocker.Unlock()

p := filepath.Join(sshPath, "authorized_keys")
f, err := os.OpenFile(p, os.O_CREATE|os.O_WRONLY|os.O_APPEND, 0600)
if err != nil {
return err
}
defer f.Close()

//os.Chmod(p, 0600)
_, err = f.WriteString(GenAuthorizedKey(key.Id, key.Content))
return err
Expand Down
12 changes: 12 additions & 0 deletions models/user.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ func UpdateUser(user *User) (err error) {

// DeleteUser completely deletes everything of the user.
func DeleteUser(user *User) error {
// Check ownership of repository.
count, err := GetRepositoryCount(user)
if err != nil {
return errors.New("modesl.GetRepositories: " + err.Error())
Expand All @@ -151,6 +152,17 @@ func DeleteUser(user *User) error {

// TODO: check issues, other repos' commits

// Delete SSH keys.
keys := make([]PublicKey, 0, 10)
if err = orm.Find(&keys, &PublicKey{OwnerId: user.Id}); err != nil {
return err
}
for _, key := range keys {
if err = DeletePublicKey(&key); err != nil {
return err
}
}

_, err = orm.Delete(user)
// TODO: delete and update follower information.
return err
Expand Down
4 changes: 4 additions & 0 deletions routers/repo/single.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Copyright 2014 The Gogs Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.

package repo

import (
Expand Down

0 comments on commit ab747f2

Please sign in to comment.