Skip to content

Commit

Permalink
Fix milestone title font problem (#22863)
Browse files Browse the repository at this point in the history
Replace #22853 since it's closed, and actually there are 2 places need
to be fixed.

~~Follow @fsologureng 's suggestion to keep the `<hX>` tags.~~ 

Update: from fsologureng: this doesn't change anything from a11y's point
of view. So I think this PR could be fine to fix the UI looking problems
as a quick patch, then defer the a11y problems to new PRs together.

Before: the font-size is too large.

After: it seems better.

![image](https://user-images.githubusercontent.com/2114189/218266257-fc2d5872-9e96-4c6a-87ea-f27531ac15c0.png)

![image](https://user-images.githubusercontent.com/2114189/218266247-efc09d83-405f-4495-967a-30d9744134ce.png)

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
  • Loading branch information
wxiaoguang and lunny committed Feb 12, 2023
1 parent e460b6e commit b0f1872
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions templates/repo/issue/milestones.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@
{{range .Milestones}}
<li class="item">
<div class="df ac sb">
<h2 class="df ac m-0 fw">
<h3 class="df ac m-0 fw">
{{svg "octicon-milestone" 16 "mr-3"}}<a class="muted" href="{{$.RepoLink}}/milestone/{{.ID}}">{{.Name}}</a>
</h2>
</h3>
<div class="df ac">
<span class="mr-3">{{.Completeness}}%</span>
<progress value="{{.Completeness}}" max="100"></progress>
Expand Down
4 changes: 2 additions & 2 deletions templates/user/dashboard/milestones.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@
{{range .Milestones}}
<li class="item">
<div class="df ac sb">
<h2 class="df ac m-0 fw">
<h3 class="df ac m-0 fw">
<span class="ui large label">{{.Repo.FullName}}</span>
{{svg "octicon-milestone" 16 "mr-3"}}<a class="muted" href="{{.Repo.Link}}/milestone/{{.ID}}">{{.Name}}</a>
</h2>
</h3>
<div class="df ac">
<span class="mr-3">{{.Completeness}}%</span>
<progress value="{{.Completeness}}" max="100"></progress>
Expand Down

0 comments on commit b0f1872

Please sign in to comment.