fine tune error message

go-gitea · May 7, 2023 · dc96bec · dc96bec
1 parent a99e830
commit dc96bec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/modules/secret/secret.go b/modules/secret/secret.go
@@ -73,7 +73,7 @@ func DecryptSecret(key, cipherHex string) (string, error) {
 	}
 	plaintext, err := AesDecrypt(keyHash[:], ciphertext)
 	if err != nil {
-		return "", fmt.Errorf("failed to decrypt by secret, secret key (SECRET_KEY) might be incorrect: %w", err)
+		return "", fmt.Errorf("failed to decrypt by secret, the key (maybe SECRET_KEY?) might be incorrect: %w", err)
 	}
 	return string(plaintext), nil
 }
diff --git a/modules/secret/secret_test.go b/modules/secret/secret_test.go
@@ -24,8 +24,8 @@ func TestEncryptDecrypt(t *testing.T) {
 	assert.ErrorContains(t, err, "invalid hex string")
 
 	_, err = DecryptSecret("a", "bb")
-	assert.ErrorContains(t, err, "secret key (SECRET_KEY) might be incorrect: AesDecrypt ciphertext too short")
+	assert.ErrorContains(t, err, "the key (maybe SECRET_KEY?) might be incorrect: AesDecrypt ciphertext too short")
 
 	_, err = DecryptSecret("a", "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef")
-	assert.ErrorContains(t, err, "secret key (SECRET_KEY) might be incorrect: AesDecrypt invalid decrtyped base64 string")
+	assert.ErrorContains(t, err, "the key (maybe SECRET_KEY?) might be incorrect: AesDecrypt invalid decrypted base64 string")
 }