Skip to content

Commit

Permalink
Fix heatmap first color being unused (#22158)
Browse files Browse the repository at this point in the history
Backport #22157. vue3-calendar-heatmap has the behaviour that the first
and second colors are mapped to values null and 0, meaning the second
color was not used as intended for values > 0. I think this is a
behaviour change from previous vue2 version that was missed during the
upgrade.

This change makes first and second values the same, so the heatmap can
now use one additional color for meaningful values.
  • Loading branch information
silverwind committed Dec 18, 2022
1 parent 4297ace commit e88218f
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions web_src/js/components/ActivityHeatmap.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export default {
},
data: () => ({
colorRange: [
'var(--color-secondary-alpha-70)',
'var(--color-secondary-alpha-70)',
'var(--color-primary-light-4)',
'var(--color-primary-light-2)',
Expand All @@ -50,6 +51,12 @@ export default {
return s;
}
},
mounted() {
// work around issue with first legend color being rendered twice and legend cut off
const legend = document.querySelector('.vch__external-legend-wrapper');
legend.setAttribute('viewBox', '12 0 80 10');
legend.style.marginRight = '-12px';
},
methods: {
handleDayClick(e) {
// Reset filter if same date is clicked
Expand Down

0 comments on commit e88218f

Please sign in to comment.