Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PushUpdateAddDeleteTags to repository module from models #10106

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 2, 2020

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 2, 2020
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, possibly with a small improvement.

modules/repository/update.go Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 3, 2020
@codecov-io
Copy link

Codecov Report

Merging #10106 into master will decrease coverage by <.01%.
The diff coverage is 13.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10106      +/-   ##
==========================================
- Coverage    43.4%    43.4%   -0.01%     
==========================================
  Files         575      576       +1     
  Lines       79640    79632       -8     
==========================================
- Hits        34567    34562       -5     
  Misses      40792    40792              
+ Partials     4281     4278       -3
Impacted Files Coverage Δ
models/helper_environment.go 90% <ø> (ø) ⬆️
routers/repo/repo.go 30.02% <0%> (ø) ⬆️
modules/repofiles/update.go 39.02% <0%> (ø) ⬆️
services/release/release.go 27.04% <0%> (ø) ⬆️
models/update.go 7.79% <100%> (+1.4%) ⬆️
models/release.go 57.52% <25%> (-0.95%) ⬇️
modules/repository/update.go 7.14% <7.14%> (ø)
models/user.go 49.24% <83.33%> (+0.08%) ⬆️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
modules/queue/unique_queue_disk_channel.go 52.56% <0%> (-1.93%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e959d1a...7ca5ef9. Read the comment docs.

@lunny
Copy link
Member Author

lunny commented Feb 3, 2020

@guillep2k done.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 3, 2020
@sapk sapk merged commit 48ce135 into go-gitea:master Feb 3, 2020
@sapk sapk added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 3, 2020
@sapk sapk added this to the 1.12.0 milestone Feb 3, 2020
@lunny lunny deleted the lunny/refactor_update branch February 3, 2020 12:06
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants