Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commenting and closing an issue at the same time button #10468

Closed
aha999 opened this issue Feb 26, 2020 · 4 comments · Fixed by #23135
Closed

Commenting and closing an issue at the same time button #10468

aha999 opened this issue Feb 26, 2020 · 4 comments · Fixed by #23135
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@aha999
Copy link

aha999 commented Feb 26, 2020 •
edited

www.codeberg.org uses Gitea so i thought i can comment here on the issue.
When you want to make a comment and close the issue with that, there's only "close" next to the comment button. I think it would be better if the option was renamed to "comment & close" so we know it's going to post a comment and then close the issue (if there is text in the comment field already). Or maybe have three options.
With only Close option some can get confused if it's going to comment and then close, or just close.

DCDZw94595

Github method:
A7Q67sS68H
@guillep2k guillep2k added type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/ui Change the appearance of the Gitea UI labels Feb 26, 2020
@JVimes
Copy link

JVimes commented Feb 24, 2023

@guillep2k #14407 says this feature exists. This might be "bug fix" instead of proposal?

@wxiaoguang wxiaoguang mentioned this issue Feb 25, 2023
Merged
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 25, 2023 •
edited

Not a bug fix, but the missing code for new editor, the new editor didn't support that .....

Will be fixed by #23135

@guillep2k
Copy link
Member

@guillep2k #14407 says this feature exists. This might be "bug fix" instead of proposal?

Ha! Is time going backwards?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 25, 2023 •
edited

The "existing" feature for rich editor is a hacky patch, it doesn't work well with real rich editors, so it got broken later.

EasyMDE/CodeMirror need to handle the onChange event.

jolheiser pushed a commit that referenced this issue Feb 27, 2023
@wxiaoguang
Change button text for commenting and closing an issue at the same ti…
8b86ccb 
…me (#23135)

Close  #10468

Without SimpleMDE/EasyMDE, using Simple Textarea, the button text could
be changed when content changes.

After introducing SimpleMDE/EasyMDE, there is no code for updating the
button text.
@yardenshoham yardenshoham mentioned this issue Feb 27, 2023
Merged
yardenshoham pushed a commit to yardenshoham/gitea that referenced this issue Feb 27, 2023
@wxiaoguang @yardenshoham
Change button text for commenting and closing an issue at the same ti…
b99bef0 
…me (go-gitea#23135)

Close  go-gitea#10468

Without SimpleMDE/EasyMDE, using Simple Textarea, the button text could
be changed when content changes.

After introducing SimpleMDE/EasyMDE, there is no code for updating the
button text.
@yardenshoham yardenshoham mentioned this issue Feb 27, 2023
Merged
yardenshoham pushed a commit to yardenshoham/gitea that referenced this issue Feb 27, 2023
@wxiaoguang @yardenshoham
Change button text for commenting and closing an issue at the same ti…
b8fd156 
…me (go-gitea#23135)

Close  go-gitea#10468

Without SimpleMDE/EasyMDE, using Simple Textarea, the button text could
be changed when content changes.

After introducing SimpleMDE/EasyMDE, there is no code for updating the
button text.
techknowlogick pushed a commit that referenced this issue Feb 28, 2023
@yardenshoham @wxiaoguang
Change button text for commenting and closing an issue at the same ti…
ff7057a 
…me (#23135) (#23182)

Backport #23135

Close  #10468

Without SimpleMDE/EasyMDE, using Simple Textarea, the button text could
be changed when content changes.

After introducing SimpleMDE/EasyMDE, there is no code for updating the
button text.



![image](https://user-images.githubusercontent.com/2114189/221334034-8d556cd5-1136-4ba0-8faa-a65ffadd7fb7.png)

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
techknowlogick pushed a commit that referenced this issue Feb 28, 2023
@yardenshoham @wxiaoguang
Change button text for commenting and closing an issue at the same ti…
ceedb49 
…me (#23135) (#23181)

Backport #23135

Close  #10468

Without SimpleMDE/EasyMDE, using Simple Textarea, the button text could
be changed when content changes.

After introducing SimpleMDE/EasyMDE, there is no code for updating the
button text.



![image](https://user-images.githubusercontent.com/2114189/221334034-8d556cd5-1136-4ba0-8faa-a65ffadd7fb7.png)

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change button text for commenting and closing an issue at the same time wxiaoguang/gitea
4 participants
@wxiaoguang @JVimes @guillep2k @aha999