Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 after activating secondary email #10547

Merged

Conversation

ashimokawa
Copy link
Contributor

After confirming a secondary email, users get redirected to a non-existing URL and get a 404, this should fix it.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 29, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 29, 2020
@ashimokawa
Copy link
Contributor Author

Shall I make a PR against v1.11 also?

@zeripath zeripath merged commit 14f3593 into go-gitea:master Feb 29, 2020
@zeripath
Copy link
Contributor

@ashimokawa Yes please send backport

@ashimokawa ashimokawa deleted the fix-landing-after-email-confim branch March 1, 2020 10:56
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Mar 1, 2020
@sapk sapk added the backport/done All backports for this PR have been created label Mar 1, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants