Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround fomantic build issue #10655

Merged
merged 1 commit into from Mar 7, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 7, 2020

This blows up the fomantic CSS by around 500kB, but I see no other way.

Ref: #10653
Ref: fomantic/Fomantic-UI#1356

This blows up the fomantic CSS by around 500kB, but I see no other way.

Ref: go-gitea#10653
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 7, 2020
@zeripath zeripath added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Mar 7, 2020
@zeripath zeripath added this to the 1.12.0 milestone Mar 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #10655 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10655   +/-   ##
=======================================
  Coverage   43.61%   43.61%           
=======================================
  Files         588      588           
  Lines       82488    82488           
=======================================
  Hits        35975    35975           
  Misses      42052    42052           
  Partials     4461     4461
Impacted Files Coverage Δ
modules/indexer/stats/db.go 50% <0%> (-9.38%) ⬇️
models/gpg_key.go 53.95% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a528189...ea6c93c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 7, 2020
@lafriks lafriks merged commit 0c2148c into go-gitea:master Mar 7, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants