Can't view Wiki pages after upgrade from 1.11.1 to 1.11.2

[sigma-frossignol]

• Gitea version (or commit ref): 1.11.2
• Git version: 2.25.1
• Operating system: Windows 2016
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

When trying to view a Wiki page I've got this message

template: repo/wiki/view:48:14: executing "repo/wiki/view" at <(not $.DisableHTTP) (and (not $.DisableSSH) (or $.IsSigned $.ExposeAnonSSH))>: can't give argument to non-function not $.DisableHTTP

Upgraded from 1.11.1 to 1.11.2 this morning and the problem appeared.
When downgrading back to 1.11.1 the problem disapears.

I had a custom template (footer.tmpl for mermaid.js) even when removing the custom template the problem persists.

I tried on a repo without Wiki, clicked start wiki saved the default page and got the message.

[sigma-frossignol]

Might be related to #10552 which shows the same error message and is said to be fixed by #10583

[alangarrison-cbts]

I am also getting this message when creating a new wiki page, just upgraded from 1.10.3 to 1.11.2.

[alangarrison-cbts]

A little more detail in my instance: In a repo with no Wiki pages, adding a new page loads the editor as expected. I get the error when saving the page, however when I go back to the Wiki page listing the page does appear to be created as it does show up. I get the template error again trying to read the new page.

[jolheiser]

This should indeed be fixed by #10583, though that fix was for Go 1.14 and Gitea 1.12, so it was never backported.
I'm unsure why this is happening in 1.11.2 since that should still be built with Go 1.13(.8), unless perhaps the bug was older than we thought?
@zeripath @techknowlogick Thoughts?

[techknowlogick]

How did you get the binary for 1.11.2, did you build it yourself? What is the output of http://gitea.example/admin/config for the Gitea Version line (it should say which version of golang is in use)? Could you try adding the fix from the linked PR to a custom template to see if that resolves the issue for you?

[alangarrison-cbts]

How did you get the binary for 1.11.2, did you build it yourself?

Downloaded "gitea-1.11.2-linux-amd64" from github.

What is the output of http://gitea.example/admin/config for the Gitea Version line (it should say which version of golang is in use)?

1.11.2 built with GNU Make 4.1, go1.14 : bindata, sqlite, sqlite_unlock_notify

Could you try adding the fix from the linked PR to a custom template to see if that resolves the issue for you?

Will try shortly.

[alangarrison-cbts]

Confirmed, using this line:
{{if or (not $.DisableHTTP) (and (not $.DisableSSH) (or $.IsSigned $.ExposeAnonSSH))}}
on line 48 of view.tmpl (per the PR) does fix the problem on my instance.

[alangarrison-cbts]

I got the same kind of error clicking on a wiki page's Revision, and grepping around the source it looks like the same kind of change will need to be made in revision.tmpl (assuming that's the proper fix).

[sigma-frossignol]

Downloaded gitea-1.11.2-windows-4.0-amd64.exe from https://dl.gitea.io/gitea/1.11.2/

Gitea version is 1.11.2 built with GNU Make 4.1, go1.14 : bindata, sqlite, sqlite_unlock_notify

[guillep2k]

Should be fixed by #10684. Closing.