Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggest optimize the event of menu on issue/PR sidebar #10926

Closed
7 tasks
a1012112796 opened this issue Apr 2, 2020 · 1 comment
Closed
7 tasks

suggest optimize the event of menu on issue/PR sidebar #10926

a1012112796 opened this issue Apr 2, 2020 · 1 comment
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@a1012112796
Copy link
Member

  • Gitea version (or commit ref):
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Hello, I have a suggestions about issue/PR sidebar menu optimize . now when we choose or remove an items on sidebar menu like labels and assignees . it will directly send post event to server. I think it's not necessary, a more good way is just save choices and do ui show. And send the results to server when choose is finished (maybe mean the menu is closed). then we can save same type choics in one comment like github style. Thanks.

jtsd
@guillep2k guillep2k added type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/ui Change the appearance of the Gitea UI labels Apr 3, 2020
a1012112796 added a commit to a1012112796/gitea that referenced this issue Aug 31, 2020
@a1012112796
Remove duplicate logic in initListSubmits
f114356 
Using the same logic to handle Choosing reviewers and assignees as
choosing label. It's the first step of go-gitea#10926.

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 mentioned this issue Aug 31, 2020
Merged
techknowlogick added a commit that referenced this issue Sep 2, 2020
@a1012112796 @techknowlogick
Remove duplicate logic in initListSubmits (#12660)
3981f1b 
* Remove duplicate logic in initListSubmits

Using the same logic to handle Choosing reviewers and assignees as
choosing label. It's the first step of #10926.

Signed-off-by: a1012112796 <1012112796@qq.com>

* fix choose block

* fix nit

* try fix bug

* simple code

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@a1012112796
Copy link
Member Author

fixed by #13304

@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guillep2k @a1012112796