Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetContents(): Dont't ignore Executables #11192

Merged
merged 6 commits into from
Apr 24, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 23, 2020

as title
fix #11190

bug is here since 1.9.0 !

@techknowlogick techknowlogick added this to the 1.12.0 milestone Apr 23, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2020
@6543
Copy link
Member Author

6543 commented Apr 24, 2020

ready to merge 🚀

@lafriks lafriks merged commit 4ddfe0d into go-gitea:master Apr 24, 2020
@lafriks lafriks deleted the fix-GetContents_11190 branch April 24, 2020 16:20
6543 added a commit to 6543-forks/gitea that referenced this pull request Apr 24, 2020
@6543
Copy link
Member Author

6543 commented Apr 24, 2020

Backport send: #11209

@lafriks lafriks added backport/done All backports for this PR have been created backport/v1.11 labels Apr 24, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* Refactor: dont expose help functions

* repofiles GetContents: dont ignore executables

* CI.restart()
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [API] GET ​/repos​/{owner}​/{repo}​/contents​/{filepath} return nul on executable files
6 participants