Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook sends wrong milestone in issue milestone change triggered message. #11295

Closed
2 tasks done
chriseaton opened this issue May 4, 2020 · 0 comments · Fixed by #11596
Closed
2 tasks done

Webhook sends wrong milestone in issue milestone change triggered message. #11295

chriseaton opened this issue May 4, 2020 · 0 comments · Fixed by #11596
Labels

Comments

@chriseaton
Copy link

  • Gitea version (or commit ref): 1.11.4
  • Git version: 1.8.3.1
  • Operating system: CentOS 7
  • Database (use [x]):
    • PostgreSQL
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes

Description

When changing the milestone of an issue, the webhook sends the old milestone on the issue instead of the new one.

Example:

  1. Issue is assigned to Milestone A.
  2. User changes issue to Milestone B.
  3. A webhook message is sent saying:

[project] Issue milestoned to Milestone A [issue name] by [user]

The language indicates what the issue was changed to, instead shows what it was changed from.

Expected result:
A webhook message is sent saying:

[project] Issue milestoned to Milestone B [issue name] by [user]

zeripath pushed a commit that referenced this issue May 24, 2020
Fixes #11295

Signed-off-by: Gary Kim gary@garykim.dev
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
Fixes go-gitea#11295

Signed-off-by: Gary Kim gary@garykim.dev
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants