Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serviceworker.js to KnownPublicEntries #11992

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jun 20, 2020

Fixes a wrong 302 redirect to the login page, see #11989. Also made it so the reserved username list is extended with those known entries so we avoid code duplication.

Should be backported to 1.12.

Fixes a wrong 302 redirect to the login page, see go-gitea#11989.
Also made it so the reserved username list is extended with those known
entries so we avoid code duplication.

Should be backported to 1.12.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 20, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 20, 2020
@lafriks lafriks merged commit e24ee48 into go-gitea:master Jun 20, 2020
@lafriks
Copy link
Member

lafriks commented Jun 20, 2020

Please backport

silverwind added a commit to silverwind/gitea that referenced this pull request Jun 20, 2020
Fixes a wrong 302 redirect to the login page, see go-gitea#11989.
Also made it so the reserved username list is extended with those known
entries so we avoid code duplication.

Should be backported to 1.12.
zeripath pushed a commit that referenced this pull request Jun 20, 2020
Fixes a wrong 302 redirect to the login page, see #11989.
Also made it so the reserved username list is extended with those known
entries so we avoid code duplication.
Bronek added a commit to Bronek/build-gitea that referenced this pull request Jun 20, 2020
@silverwind silverwind deleted the entries branch June 20, 2020 15:43
@zeripath zeripath added the backport/done All backports for this PR have been created label Jul 1, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Fixes a wrong 302 redirect to the login page, see go-gitea#11989.
Also made it so the reserved username list is extended with those known
entries so we avoid code duplication.

Should be backported to 1.12.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants