Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change custom OAuth2 Nextcloud URL #12014

Closed
2 tasks done
SohnyBohny opened this issue Jun 22, 2020 · 5 comments · Fixed by #14137
Closed
2 tasks done

Cannot change custom OAuth2 Nextcloud URL #12014

SohnyBohny opened this issue Jun 22, 2020 · 5 comments · Fixed by #14137
Labels

Comments

@SohnyBohny
Copy link
Contributor

  • Gitea version (or commit ref):
  • Git version:
  • Operating system:
  • Database (use [x]):
    • MySQL
  • Can you reproduce the bug at https://try.gitea.io:
    • No (admin)
  • Log gist:

Description

Cannot change custom OAuth2 Nextcloud URL default entries.

Screenshots

Screen Capture

@SohnyBohny
Copy link
Contributor Author

Small update: It's only a UI problem. Internally the changes are applied.

@stale
Copy link

stale bot commented Aug 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 23, 2020
@SohnyBohny
Copy link
Contributor Author

For me the problem still exists. Maybe someone else could test an confirm this bug.

@stale stale bot removed the issue/stale label Aug 24, 2020
@dugite-code
Copy link

dugite-code commented Aug 27, 2020

I was just setting this up and I see it as well. This is an issue as if you update the CLIENT ID or Secret without re-typing the correct domain it will overwrite your valid url

Gitea: Docker 1.13.0+dev-418-gd285b5d35
DB: sqlite

@nuno-silva
Copy link
Contributor

I'm seeing this issue as of gitea 1.12.4 using the Gitea auth source. The the fields are updated internally and are correct in the /admin/auths/<id> page response, but then it seems the java-script resets them to the default values. If I disable java-script I can see the correct endpoint values in the UI.

zeripath pushed a commit that referenced this issue Dec 26, 2020
* do not override OAuth URLs with default values when editing an auth source (fixes #12014)
* show custom url inputs by default for providers that don't provide an official hosted service
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants