Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paste image (via CTRL+V) not working when adding review comment #12183

Closed
2 of 7 tasks
LukeOwlclaw opened this issue Jul 8, 2020 · 2 comments
Closed
2 of 7 tasks

Paste image (via CTRL+V) not working when adding review comment #12183

LukeOwlclaw opened this issue Jul 8, 2020 · 2 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.22.0

Comments

@LukeOwlclaw
Copy link

Description

Leaving an image using CTRL+V does not work here:
image
@a1012112796
Copy link
Member

Sadly Code comment and review do not support attachment now.

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jul 8, 2020
@wxiaoguang wxiaoguang mentioned this issue Apr 29, 2023
Closed
jpraet added a commit to jpraet/gitea that referenced this issue Feb 17, 2024
@jpraet
Add attachment support for code review comments
6917acc 
Fixes go-gitea#27960, go-gitea#24411, go-gitea#12183
@jpraet jpraet mentioned this issue Feb 17, 2024
Merged
lunny pushed a commit that referenced this issue Feb 25, 2024
@jpraet @wxiaoguang
Add attachment support for code review comments (#29220)
2e33671 
Fixes #27960, #24411, #12183

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@lafriks
Copy link
Member

lafriks commented May 28, 2024

Should be fixed by #29220, please reopen if not working

@lafriks lafriks closed this as completed May 28, 2024
@lafriks lafriks added this to the 1.22.0 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.22.0
Development

No branches or pull requests
4 participants
@lunny @lafriks @LukeOwlclaw @a1012112796