Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make generate-images fails with newer inkscape versions #12314

Closed
1 of 7 tasks
stertingen opened this issue Jul 24, 2020 · 2 comments · Fixed by #12316
Closed
1 of 7 tasks

make generate-images fails with newer inkscape versions #12314

stertingen opened this issue Jul 24, 2020 · 2 comments · Fixed by #12316

Comments

@stertingen
Copy link

stertingen commented Jul 24, 2020 •
edited
Loading

  • Gitea version (or commit ref): 7744b36
  • Git version: not relevant
  • Operating system: not relevant
  • Database (use [x]): not relevant
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

make generate-images fails with newer inkscape versions (version 1.0) because some CLI arguments have changed.

References:
https://inkscape.org/sk/doc/inkscape-man.html
https://wiki.inkscape.org/wiki/index.php/Using_the_Command_Line#Changes_from_0.92

Instead of inkscape -f <infile> ... -e <outfile>, it should be inkscape <infile> ... --export-file=<outfile>.

(I stumbled upon this when creating my own Gitea logo)

This could be helpful:
inkscape --version 2>/dev/null | cut -d ' ' -f 2 | cut -d . -f 1 prints the major inkscape version which then can be compared to '0' or '1'.
@silverwind silverwind mentioned this issue Jul 24, 2020
Merged
@silverwind
Copy link
Member

Should be resolved with #12316 if you want to give it a try.

@stertingen
Copy link
Author

Should be resolved with #12316 if you want to give it a try.

This works, thanks!

silverwind added a commit to silverwind/gitea that referenced this issue Jul 25, 2020
@silverwind
Rework 'make generate-images'
9e1edbf 
- Remove external dependencies and replace it with a node script that
  does does the same.
- Move detail removal from gitea-sm.png to favicon.png
- Remove favicon.ico and its generation, it is unused and we already serve
  favicon.png in its place.

Fixes: go-gitea#12314
lunny pushed a commit that referenced this issue Jul 26, 2020
@silverwind
Rework 'make generate-images' (#12316)
7cf2339 
* Rework 'make generate-images'

- Remove external dependencies and replace it with a node script that
  does does the same.
- Move detail removal from gitea-sm.png to favicon.png
- Remove favicon.ico and its generation, it is unused and we already serve
  favicon.png in its place.

Fixes: #12314

* use proper centering value for preserveAspectRatio

* fix lint

* use fabric

* better linting fix

* fix typo

* mention detail-remove class in docs
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework 'make generate-images' silverwind/gitea
2 participants
@silverwind @stertingen