Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If adding two images in the description when creating a new issue, only the first is clickable. #12925

Closed
1 of 3 tasks
Floaf opened this issue Sep 23, 2020 · 10 comments · Fixed by #14979
Closed
1 of 3 tasks
Labels
Milestone

Comments

@Floaf
Copy link

Floaf commented Sep 23, 2020

If adding two images (by pasting them in the text field) in the description when creating a new issue, only the first is clickable.

image
image
Only 1 is clickable, not 2.

@bagasme
Copy link
Contributor

bagasme commented Sep 24, 2020

@Floaf on which previous version/commit this issue doesn't occur?

@Floaf
Copy link
Author

Floaf commented Sep 24, 2020

I have no idea, I just noticed it and assumed it was a bug since it makes not sense to only have the first image clickable.

@bagasme
Copy link
Contributor

bagasme commented Sep 24, 2020

@Floaf can you test latest stable version (1.12.4)?

@Floaf
Copy link
Author

Floaf commented Sep 24, 2020

@bagasme Not easily :-/

But i am running 1.12.1 (stable) in my environment and the same bug is there so maybe it never worked.

@bagasme
Copy link
Contributor

bagasme commented Sep 25, 2020

@Floaf I can confirm the issue. On my case, the issue appeared on latest master (commit 3c36080).

@bagasme
Copy link
Contributor

bagasme commented Sep 25, 2020

@Floaf As workaround try to right-click second image and click View image (if you're on Firefox)

@Floaf
Copy link
Author

Floaf commented Sep 25, 2020

@bagasme Yes, thanks. The links under the comment, "image.png", works too.
I just wanted to mention it if no one has noticed it.

@zeripath
Copy link
Contributor

if you add a blank line between the two images the images are linked.

@bagasme
Copy link
Contributor

bagasme commented Sep 26, 2020

@zeripath Your workaround also worked too

@fnetX
Copy link
Contributor

fnetX commented Mar 8, 2021

I'd nevertheless say this is a bug, right? 😅 Still reproducible on https://try.gitea.io/fnetx/general/issues/1 (with html linebreak)

Came to this via https://codeberg.org/Codeberg/Community/issues/340

zeripath added a commit to zeripath/gitea that referenced this issue Mar 12, 2021
Due a problem with the ast.Walker in the our transformer in goldmark
an image with a sibling image will not be transformed to gain a parent
link. This PR fixes this.

Fix go-gitea#12925

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.5 milestone Mar 12, 2021
zeripath added a commit that referenced this issue Mar 14, 2021
* Make sure sibling images get a link too

Due a problem with the ast.Walker in the our transformer in goldmark
an image with a sibling image will not be transformed to gain a parent
link. This PR fixes this.

Fix #12925

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this issue Mar 14, 2021
Backport go-gitea#14979

Due a problem with the ast.Walker in the our transformer in goldmark
an image with a sibling image will not be transformed to gain a parent
link. This PR fixes this.

Fix go-gitea#12925

Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny pushed a commit that referenced this issue Mar 15, 2021
Backport #14979

Due a problem with the ast.Walker in the our transformer in goldmark
an image with a sibling image will not be transformed to gain a parent
link. This PR fixes this.

Fix #12925

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants