-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If adding two images in the description when creating a new issue, only the first is clickable. #12925
Comments
@Floaf on which previous version/commit this issue doesn't occur? |
I have no idea, I just noticed it and assumed it was a bug since it makes not sense to only have the first image clickable. |
@Floaf can you test latest stable version (1.12.4)? |
@bagasme Not easily :-/ But i am running 1.12.1 (stable) in my environment and the same bug is there so maybe it never worked. |
@Floaf As workaround try to right-click second image and click |
@bagasme Yes, thanks. The links under the comment, "image.png", works too. |
if you add a blank line between the two images the images are linked. |
@zeripath Your workaround also worked too |
I'd nevertheless say this is a bug, right? 😅 Still reproducible on https://try.gitea.io/fnetx/general/issues/1 (with html linebreak) Came to this via https://codeberg.org/Codeberg/Community/issues/340 |
Due a problem with the ast.Walker in the our transformer in goldmark an image with a sibling image will not be transformed to gain a parent link. This PR fixes this. Fix go-gitea#12925 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Make sure sibling images get a link too Due a problem with the ast.Walker in the our transformer in goldmark an image with a sibling image will not be transformed to gain a parent link. This PR fixes this. Fix #12925 Signed-off-by: Andrew Thornton <art27@cantab.net>
Backport go-gitea#14979 Due a problem with the ast.Walker in the our transformer in goldmark an image with a sibling image will not be transformed to gain a parent link. This PR fixes this. Fix go-gitea#12925 Signed-off-by: Andrew Thornton <art27@cantab.net>
If adding two images (by pasting them in the text field) in the description when creating a new issue, only the first is clickable.
Only 1 is clickable, not 2.
The text was updated successfully, but these errors were encountered: