Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment box tweaks and SVG dropdown triangles #13376

Merged
merged 7 commits into from
Oct 31, 2020
Merged

Comment box tweaks and SVG dropdown triangles #13376

merged 7 commits into from
Oct 31, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Oct 31, 2020 •
edited
Loading

  • Change all dropdown triangles to SVG
  • Bring inline review comment box closer to regular comment boxes
  • Enhance arc-green checkbox contrast
  • Minor reaction tweaks
  • Flexbox the diff file header

Screen Shot 2020-10-31 at 18 06 02

Screen Shot 2020-10-31 at 19 31 27

image

@silverwind
Comment box tweaks and SVG dropdown triangles
a7f669c 
- Change all dropdown triangles to SVG
- Bring inline review comment box closer to regular comment boxes
- Enhance arc-green checkbox contrast
- Minor reaction tweaks
- Flexbox the diff file header
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 31, 2020
zeripath
zeripath approved these changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more thanks for these changes.

We should be careful though that with the octiconning of the UI we don't end up looking too much like GH

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2020
@silverwind
Copy link
Member Author

silverwind commented Oct 31, 2020 •
edited
Loading

Doesn't have to be strictly octicons but I came to like them. I mainly want to get rid of the icon fonts because they flash ugly placeholders for me on page load.

@silverwind
Copy link
Member Author

silverwind commented Oct 31, 2020 •
edited
Loading

BTW, those two comment box templates are like 95% the same, except they use slightly different context variables.

@silverwind
Copy link
Member Author

Done pushing tweaks :)

@silverwind
Copy link
Member Author

Noticed a regression with the triangle position, hold on.

@techknowlogick techknowlogick added this to the 1.14.0 milestone Oct 31, 2020
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Oct 31, 2020
@silverwind
Copy link
Member Author

Regression fixed. Turns out Fomantic needed those old classes for its positioning.

@techknowlogick techknowlogick merged commit 2ac112d into go-gitea:master Oct 31, 2020
@silverwind silverwind deleted the csstweaks2 branch October 31, 2020 22:18
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

Hello there.
Is it possible I am getting the below because of this?
image

@silverwind
Copy link
Member Author

Yes, I saw something similar. #13378 should have the fix.

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf @lafriks @zeripath @techknowlogick @GiteaBot