Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blame misalignment on wrapped lines #13540

Closed
silverwind opened this issue Nov 13, 2020 · 0 comments · Fixed by #13542
Closed

Blame misalignment on wrapped lines #13540

silverwind opened this issue Nov 13, 2020 · 0 comments · Fixed by #13542
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.14.0

Comments

@silverwind
Copy link
Member

When a long line is wrapped on blame, the blame info will get out of alignment with the code. I think we need to disable line wrapping in blame again. Long term solution will be to rewrite blame HTML to not have separate columns for info and code.

Should only affect 1.14 unless we did wrap on 1.13 too.
@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI labels Nov 13, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 13, 2020
@silverwind silverwind mentioned this issue Nov 13, 2020
Merged
silverwind added a commit to silverwind/gitea that referenced this issue Nov 13, 2020
@silverwind
Fix blame line alignment
cb33fcc 
We can't wrap code in blame because it's essentially two tables
side-by-side which will misalign them when one line gets larger.

Fixes: go-gitea#13540
Regressed by: go-gitea#13415
techknowlogick added a commit that referenced this issue Nov 13, 2020
@silverwind @techknowlogick
Fix blame line alignment (#13542)
db16275 
We can't wrap code in blame because it's essentially two tables
side-by-side which will misalign them when one line gets larger.

Fixes: #13540
Regressed by: #13415

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging a pull request may close this issue.

Fix blame line alignment silverwind/gitea
2 participants
@silverwind @lafriks