Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add review requests filter on pull request overview #13682

Closed
jpraet opened this issue Nov 23, 2020 · 4 comments · Fixed by #13701
Closed

Add review requests filter on pull request overview #13682

jpraet opened this issue Nov 23, 2020 · 4 comments · Fixed by #13701
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@jpraet
Copy link
Member

jpraet commented Nov 23, 2020

Description

A "Review requests" filter can be added on the pull request overview page.

Currently these 4 filter options exist:
image

An additional option "Review requests" can be added, just like on github:

image

I'm currently working on a pull request for this. I am uncertain about something though: should this filter also return review requests that you have already accepted at some point, but have gone stale by now?
@6543 6543 added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Nov 23, 2020
@6543
Copy link
Member

6543 commented Nov 23, 2020 •
edited
Loading

I'm not sure if I think it should be "Reviewed requestsed" ... and I think is should not matter if it's stale or not ...

@jpraet
Copy link
Member Author

jpraet commented Nov 23, 2020

@6543 Did you mean "Review requested"? I'm not sure about the name either. If you want to avoid any confusion then maybe something along the lines of "Requesting your review"?

I just thought of another pull request filter that I would like to add: "Pending review". That way you can easily retrieve the pull requests for which you have pending review comments. Would you prefer a separate ticket and PR for that, or can I combine these in one PR?

@6543
Copy link
Member

6543 commented Nov 23, 2020

I think fitering by review is nice - but if we add 3 different review-filter we overload the UI. there should be nice & clean ui for this

This was referenced Nov 25, 2020
Merged
Closed
jpraet added a commit to kszbcss/gitea that referenced this issue Nov 28, 2020
@jpraet
Add review pending filter on pull request overview go-gitea#13682
216c227 
fix formatting
@jpraet
Copy link
Member Author

jpraet commented Dec 7, 2020

Some of the existing pull request filters are not very useful to me:

  • In your repositories: too overwhelming, I may have access to 100's of repo's, but it doesn't mean I'm interested in all their PR's
  • Assigned to you: not sure what "Assigned" is supposed to mean for a PR, it's more suited for issues?
  • Created by you: Yes, this is useful
  • Mentioning you: Yes, this is useful

What I am looking for is a list of PR's that require my attention:

  • Review requested
  • Pending review
  • Official review: PR's for which I am in the whitelist for restricted approvals

jpraet added a commit to kszbcss/gitea that referenced this issue Dec 22, 2020
@jpraet
Add review requested filter on pull request overview go-gitea#13682
8d0a527 
fix formatting
6543 pushed a commit that referenced this issue Jan 17, 2021
@jpraet
Add review requested filter on pull request overview (#13701)
acb1ceb 
* Add review requested filter on pull request overview #13682

fix formatting

* add review_requested filter to /repos/issues/search API endpoint

* only Approve and Reject status should supersede Request status

* add support for team reviews

* refactor: remove duplication of issue filtering conditions
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add review requested filter on pull request overview kszbcss/gitea
2 participants
@jpraet @6543