Add class to page content to unify top margin #13766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's a shame to have to change so many files. Is there really no way to use CSS selectors to do this? |
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Nov 30, 2020
GiteaBot
added
lgtm/need 1
|
Not really, the pages use various classes for the root content element which makes them hard to consistently target for things like this. |
|
I do believe it's possible with CSS selectors but I also think such a class is generally useful to have and might come in handy for the future. |
lafriks
approved these changes
Nov 30, 2020
GiteaBot
added
lgtm/done
Previously pages would individually set this margin but some didn't so content would stick to the header without any space. Resolve this by adding a new class that is added on all pages. The only place where we remove this margin again is on the pages with menu or wrapper in the header.
lafriks
added
the
skip-changelog
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously pages would individually set this margin but some didn't so content would stick to the header without any space. Resolve this by adding a new class that is added on all pages. The only place where we remove this margin again is on the pages with menu or wrapper in the header.
Before:
After:
