Whenever the password is updated ensure that the hash algorithm is too #13966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`user.HashPassword` may potentially - and in fact now likely does - change the `passwd_hash_algo` therefore whenever the `passwd` is updated, this also needs to be updated. Fix go-gitea#13832 Thanks @fblaese for the hint Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick
approved these changes
Dec 12, 2020
GiteaBot
added
the
lgtm/need 1
jolheiser
approved these changes
Dec 12, 2020
GiteaBot
added
lgtm/done
6543
approved these changes
Dec 12, 2020
|
@zeripath backport 🙃 |
zeripath
deleted the
fix-13832-update-password-algorithm-with-passwd-change
branch
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Dec 12, 2020
go-gitea#13966) Backport go-gitea#13966 `user.HashPassword` may potentially - and in fact now likely does - change the `passwd_hash_algo` therefore whenever the `passwd` is updated, this also needs to be updated. Fix go-gitea#13832 Thanks @fblaese for the hint Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user.HashPasswordmay potentially - and in fact now likely does - change thepasswd_hash_algotherefore whenever thepasswdis updated, this also needs to be updated.Fix #13832
Thanks @fblaese for the hint
Signed-off-by: Andrew Thornton art27@cantab.net