mentions are not persisted when ENABLE_NOTIFY_MAIL=false

[jpraet]

Gitea version (or commit ref): 1.14.0

Description

When ENABLE_NOTIFY_MAIL in app.ini is set to false, mentions in issues / pulls are not persisted (so not listed in the "Mentioning You" filter on the dashboard).

[zeripath]

gitea/services/mailer/mail_comment.go

Lines 21 to 29 in ac88b0e

	func mailParticipantsComment(ctx models.DBContext, c *models.Comment, opType models.ActionType, issue *models.Issue) (err error) {
	rawMentions := references.FindAllMentionsMarkdown(c.Content)
	userMentions, err := issue.ResolveMentionsByVisibility(ctx, c.Poster, rawMentions)
	if err != nil {
	return fmt.Errorf("ResolveMentionsByVisibility [%d]: %v", c.IssueID, err)
	}
	if err = models.UpdateIssueMentions(ctx, c.IssueID, userMentions); err != nil {
	return fmt.Errorf("UpdateIssueMentions [%d]: %v", c.IssueID, err)
	}

This logic does not belong in mail_comment.go

[jpraet]

I'm working on a PR, combined with #14013.

[zeripath]

I would not be at all surprised if that had the same root cause