Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kd/fix allow svg doctype #14344

Merged
merged 5 commits into from
Jan 15, 2021
Merged

Kd/fix allow svg doctype #14344

merged 5 commits into from
Jan 15, 2021

Conversation

kdumontnu
Copy link
Contributor

@kdumontnu kdumontnu commented Jan 15, 2021 •
edited
Loading

Closes #14328

  • Uses <svg[\s>\/] instead of <svg\b to make sure we won't capture non-svg elements
  • Uses case-insensitive regex
  • Adds a filter to optionally allow doctype declarations for svg only (even though MDN recommends against doctypes for svg they are still commonly used)
  • Adds test for doctype

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 15, 2021
@lafriks lafriks added type/enhancement An improvement of existing functionality skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 15, 2021
@lafriks lafriks added this to the 1.14.0 milestone Jan 15, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2021
@lunny lunny merged commit bfd0c47 into go-gitea:master Jan 15, 2021
@kdumontnu kdumontnu deleted the kd/fix-allow_svg__doctype branch January 15, 2021 16:44
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Add DOCTYPE as valid svg format
4 participants
@kdumontnu @lunny @lafriks @GiteaBot