Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stopwatches endpoint should not be triggered when ENABLE_TIMETRACKING = false #14435

Closed
jpraet opened this issue Jan 22, 2021 · 1 comment · Fixed by #14750
Closed

stopwatches endpoint should not be triggered when ENABLE_TIMETRACKING = false #14435

jpraet opened this issue Jan 22, 2021 · 1 comment · Fixed by #14750
Assignees
@noerw
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Milestone
1.14.0

Comments

@jpraet
Copy link
Member

jpraet commented Jan 22, 2021 •
edited
Loading

  • Gitea version: 1.14

Description

The /api/v1/user/stopwatches endpoint is queried every 10 seconds, even when ENABLE_TIMETRACKING = false in app.ini

2021/01/22 20:38:03 Started GET /api/v1/user/stopwatches for 127.0.0.1:52339
2021/01/22 20:38:03 Completed GET /api/v1/user/stopwatches 200 OK in 9.9781ms
2021/01/22 20:38:13 Started GET /api/v1/user/stopwatches for 127.0.0.1:52339
2021/01/22 20:38:13 Completed GET /api/v1/user/stopwatches 200 OK in 11.0478ms
2021/01/22 20:38:23 Started GET /api/v1/user/stopwatches for 127.0.0.1:52339
2021/01/22 20:38:24 Completed GET /api/v1/user/stopwatches 200 OK in 8.9847ms
2021/01/22 20:38:34 Started GET /api/v1/user/stopwatches for 127.0.0.1:52339
2021/01/22 20:38:34 Completed GET /api/v1/user/stopwatches 200 OK in 10.9856ms
2021/01/22 20:38:44 Started GET /api/v1/user/stopwatches for 127.0.0.1:52339
2021/01/22 20:38:44 Completed GET /api/v1/user/stopwatches 200 OK in 10.0009ms
2021/01/22 20:38:54 Started GET /api/v1/user/stopwatches for 127.0.0.1:52339
2021/01/22 20:38:54 Completed GET /api/v1/user/stopwatches 200 OK in 9.9988ms
2021/01/22 20:39:04 Started GET /api/v1/user/stopwatches for 127.0.0.1:52339
2021/01/22 20:39:04 Completed GET /api/v1/user/stopwatches 200 OK in 10.0026ms
2021/01/22 20:39:14 Started GET /api/v1/user/stopwatches for 127.0.0.1:52339
2021/01/22 20:39:14 Completed GET /api/v1/user/stopwatches 200 OK in 10.9982ms

Relates to #14122
@6543 6543 added the type/bug label Jan 22, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 22, 2021
@6543
Copy link
Member

6543 commented Jan 22, 2021

regression of #14122

@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 23, 2021
@noerw noerw self-assigned this Feb 19, 2021
noerw added a commit to noerw/gitea that referenced this issue Feb 19, 2021
@noerw
stopwatch notif: check if timetracking is enabled
e6490a8 
fixes go-gitea#14435
@noerw noerw mentioned this issue Feb 19, 2021
Merged
6543 pushed a commit that referenced this issue Feb 19, 2021
@noerw
stopwatch notif: check if timetracking is enabled (#14750)
91424ff 
fixes #14435
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@noerw noerw

Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging a pull request may close this issue.

stopwatch notif: check if timetracking is enabled noerw/gitea
4 participants
@lunny @jpraet @noerw @6543