Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easyMDE(simpleMDE) support for release content editor #14744

Merged
merged 10 commits into from
Feb 22, 2021

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Feb 19, 2021

As title

example view:
1


2


3

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 added the topic/ui Change the appearance of the Gitea UI label Feb 19, 2021
@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #14744 (dc6d29a) into master (487f2ee) will increase coverage by 0.01%.
The diff coverage is 42.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14744      +/-   ##
==========================================
+ Coverage   42.21%   42.23%   +0.01%     
==========================================
  Files         767      771       +4     
  Lines       81624    82086     +462     
==========================================
+ Hits        34458    34666     +208     
- Misses      41531    41779     +248     
- Partials     5635     5641       +6     
Impacted Files Coverage Δ
models/action.go 48.52% <0.00%> (-2.42%) ⬇️
models/migrations/migrations.go 2.59% <ø> (ø)
models/migrations/v166.go 0.00% <0.00%> (ø)
models/migrations/v172.go 0.00% <0.00%> (ø)
models/migrations/v173.go 0.00% <0.00%> (ø)
models/session.go 0.00% <0.00%> (ø)
models/user.go 53.05% <ø> (+0.38%) ⬆️
modules/context/context.go 58.05% <0.00%> (-0.45%) ⬇️
modules/indexer/code/elastic_search.go 1.72% <0.00%> (-0.02%) ⬇️
modules/migrations/github.go 77.77% <0.00%> (-1.99%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6068c1...dc6d29a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 20, 2021
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the preview page and are happy that relative links from it match when they are finally rendered?

@a1012112796
Copy link
Member Author

Have you tested the preview page and are happy that relative links from it match when they are finally rendered?

yes, see #14744 (comment)

@zeripath
Copy link
Contributor

I was meaning links like:

[README.md]

@a1012112796
Copy link
Member Author

I was meaning links like:

[README.md]

It's a link?
image

@zeripath
Copy link
Contributor

Sorry [README.md](README.md)

@a1012112796
Copy link
Member Author

Sorry [README.md](README.md)

the results is same:
tp

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 21, 2021
@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 22, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2021
@lunny lunny added this to the 1.14.0 milestone Feb 22, 2021
@6543
Copy link
Member

6543 commented Feb 22, 2021

🚀

@6543 6543 merged commit 5d2b7ba into go-gitea:master Feb 22, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants