Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new issue from code #14863

Merged
merged 8 commits into from
Mar 18, 2021
Merged

Create new issue from code #14863

merged 8 commits into from
Mar 18, 2021

Conversation

rogerluo410
Copy link
Contributor

@rogerluo410 rogerluo410 commented Mar 3, 2021 •
edited
Loading

Feat: add reference in new issue with permalink menu for code view.

For feature: issue from code:
#6125

vdpna-4si3s

@rogerluo410 rogerluo410 changed the title Feat: Implement feature creating issue from code Feature for new issue from code Mar 4, 2021
@rogerluo410 rogerluo410 changed the title Feature for new issue from code Feature for new issue of repo from code Mar 4, 2021
zeripath
zeripath reviewed Mar 4, 2021
View reviewed changes
routers/repo/issue.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2021
zeripath
zeripath reviewed Mar 4, 2021
View reviewed changes
routers/repo/view.go Outdated Show resolved Hide resolved
templates/repo/view_file.tmpl Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Mar 7, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there! Thanks for your changes.

templates/repo/issue/comment_tab.tmpl Outdated Show resolved Hide resolved
templates/repo/view_file.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 8, 2021
noerw
noerw approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@noerw noerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 8, 2021
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 8, 2021
@lunny lunny added this to the 1.15.0 milestone Mar 8, 2021
@lafriks lafriks modified the milestones: 1.15.0, 1.14.0 Mar 17, 2021
@lafriks lafriks changed the title Feature for new issue of repo from code Create new issue from code Mar 17, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 119d2cb into go-gitea:master Mar 18, 2021
@6543 6543 mentioned this pull request Mar 18, 2021
Merged
1 task
jolheiser pushed a commit to jolheiser/gitea that referenced this pull request Mar 18, 2021
@rogerluo410 @lafriks
@6543 @jolheiser
Create new issue from code (go-gitea#14863)
8b70113 
* Feat: add reference in new issue with permalink menu for code view.

* Fix: recover index.js file.

* Add comments and redo ci.

* Fix code convention

* Fix code.

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

@noerw noerw noerw approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
8 participants
@rogerluo410 @techknowlogick @lafriks @zeripath @noerw @lunny @GiteaBot @6543