Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue list template render panic #14906

Closed
lunny opened this issue Mar 6, 2021 · 0 comments · Fixed by #14911
Closed

Issue list template render panic #14906

lunny opened this issue Mar 6, 2021 · 0 comments · Fixed by #14911
Labels
type/bug

Comments

@lunny
Copy link
Member

lunny commented Mar 6, 2021 

2021/03/06 12:21:38 ...s/context/context.go:194:HTML() [E] Render failed: template: repo/issue/list:59:23: executing "repo/issue/list" at <eq $.MilestoneID .ID>: error calling eq: incompatible types for comparison
	/source/modules/context/context.go:194 (0x1b36225)
	/source/routers/repo/issue.go:396 (0x208d574)
	/source/modules/web/route.go:53 (0x1f64d82)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/mux.go:436 (0x1b2d0ca)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/web/route.go:91 (0x1f65316)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/web/route.go:91 (0x1f65316)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/web/route.go:91 (0x1f65316)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x21946a1)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/context/context.go:672 (0x1b49061)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/base.go:91 (0x219b95a)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/base.go:91 (0x219b95a)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/public/public.go:85 (0x13eee87)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/modules/public/public.go:85 (0x13eee87)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/base.go:190 (0x219d470)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/gitea.com/go-chi/session/session.go:256 (0x153daae)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/mux.go:70 (0x1b2ac2a)
	/source/vendor/github.com/go-chi/chi/mux.go:311 (0x1b3101b)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/mux.go:436 (0x1b2d0ca)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/web.go:93 (0x219e8bd)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/base.go:37 (0x219a61b)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x2195087)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/middleware/realip.go:34 (0x2194f3c)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/routers/routes/web.go:65 (0x219e3fc)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/source/vendor/github.com/go-chi/chi/mux.go:87 (0x1b2a9b0)
	/source/modules/web/route.go:267 (0x1f642d3)
	/source/vendor/github.com/gorilla/context/context.go:141 (0x11b00b3)
	/usr/local/go/src/net/http/server.go:2069 (0x7bd0a3)
	/usr/local/go/src/net/http/server.go:2887 (0x7c0662)
	/usr/local/go/src/net/http/server.go:1952 (0x7bbb8c)
	/usr/local/go/src/runtime/asm_amd64.s:1371 (0x47a460)
@lunny lunny added the type/bug label Mar 6, 2021
zeripath added a commit to zeripath/gitea that referenced this issue Mar 6, 2021
@zeripath
Prevent panic when empty MilestoneID in repo/issue/list
4722c57 
This PR adds a simple check to only test the MilestoneID if it is not empty.

Fix go-gitea#14906

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Mar 6, 2021
Merged
lunny pushed a commit that referenced this issue Mar 7, 2021
@zeripath @techknowlogick
Prevent panic when empty MilestoneID in repo/issue/list (#14911)
beed547 
This PR adds a simple check to only test the MilestoneID if it is not empty.

Fix #14906

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent panic when empty MilestoneID in repo/issue/list zeripath/gitea
1 participant
@lunny