Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch page and misc css improvements #15208

Merged
merged 2 commits into from
Apr 3, 2021
Merged

Branch page and misc css improvements #15208

merged 2 commits into from
Apr 3, 2021

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 30, 2021 •
edited

  • Improve branches page, increase icon size, use octicons, use css vars
  • Style placeholder color via css var
  • Slightly increase contrast of input fields and active/hover states
  • Add styling for select boxes in arc-green

image

image

Select boxes before and after:
Screen Shot 2021-03-30 at 20 01 43
Screen Shot 2021-03-30 at 20 11 34

@silverwind silverwind added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 30, 2021
@silverwind silverwind added this to the 1.15.0 milestone Mar 30, 2021
@silverwind
Branch page and misc css improvements
889543c 
- Improve branches page, increase icon size, use octicons, use css vars
- Style placeholder color via css var
- Slightly increase contrast of input fields and active/hover states
- Add styling for select boxes in arc-green
@silverwind silverwind modified the milestones: 1.15.0, 1.14.0 Mar 30, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 3, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2021
@6543 6543 merged commit d0c9b3e into go-gitea:master Apr 3, 2021
@6543 6543 modified the milestones: 1.14.0, 1.15.0 Apr 3, 2021
@6543 6543 removed the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 3, 2021
@CL-Jeremy
Copy link
Contributor

Is it possible to make this select element a real dropdown (I know we dislike JS but still).

@zeripath
Copy link
Contributor

zeripath commented Apr 3, 2021

yeah it should be possible to do this by adding dropdown to a class - would you like to try?

silverwind added a commit to silverwind/gitea that referenced this pull request Apr 4, 2021
@silverwind
Branch page and misc css improvements (go-gitea#15208)
cda6f76 
- Improve branches page, increase icon size, use octicons, use css vars
- Style placeholder color via css var
- Slightly increase contrast of input fields and active/hover states
- Add styling for select boxes in arc-green
@silverwind silverwind mentioned this pull request Apr 4, 2021
Merged
@silverwind silverwind deleted the csstweaks20 branch April 4, 2021 09:58
@silverwind
Copy link
Member Author

Is it possible to make this select element a real dropdown

Yes that'd be preferred. I was surprised to see a <select>, I think it's the first such usage. I don't see anything inherently wrong in it besides the arrow being a bit ugly but using it over a dropdown has accessibilty benefits.

lafriks pushed a commit that referenced this pull request Apr 4, 2021
@silverwind
Branch page and misc css improvements (#15208) (#15274)
4bc8dfc 
- Improve branches page, increase icon size, use octicons, use css vars
- Style placeholder color via css var
- Slightly increase contrast of input fields and active/hover states
- Add styling for select boxes in arc-green
@CL-Jeremy CL-Jeremy mentioned this pull request Apr 4, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Apr 7, 2021
@CL-Jeremy CL-Jeremy mentioned this pull request Apr 9, 2021
Merged
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @CL-Jeremy @zeripath @6543 @GiteaBot