Kd/fix release compare extra bracket #15988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
approved these changes
May 26, 2021
GiteaBot
added
the
lgtm/need 1
kdumontnu
added
backport/v1.14
lgtm/need 1
noerw
approved these changes
May 26, 2021
GiteaBot
added
lgtm/done
|
I think the sqlite test fail is related |
Thanks, yeah. Looks like the tags are coming back in a different order. Which seems odd to me... Perhaps I should create a separate PR to add the test (just merge the fix for now) |
Sounds good. |
kdumontnu
force-pushed
the
kd/fix_release-compare-extra-bracket
branch
from
b11de63
to
e40cc69
Compare
|
@kdumontnu please send backport :) |
@techknowlogick after checking the v1.14 code it looks like this doesn't need a backport |
zeripath
added
the
skip-changelog
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extra brace (
}) was causing the release compare function to break. This PR fixes that and adds an integration test to parse the HTML for the compare dropdown.