update git and fix #1133

[lunny]

will fix #1133

[sapk]

LGTM and drone will check if vendoring is good ^^

[lunny]

@sapk, I think maybe the check has some wrong. The vendor package could be older than the original package. It's not an error.

[lunny]

And I have run govendor status +outside +unused on my branch, it shows

The following packages are missing or modified locally:
       	github.com/go-xorm/core
       	github.com/go-xorm/xorm

But the drone said code.gitea.io/git is missing or modified locally. So I think maybe the vendor-test has something wrong.

[sapk]

File command_test.go is missing go-gitea/git@135704d...go-gitea:3f99247c0da807afc967c7e12b14f4109b7490ff to be compliant with commit 3f99247

What did you used to update vendor ?

[sapk]

Can you try to do a govendor sync ? It should add file command_test.go and do a git add to commit it.

[lunny]

I used govendor update. I will update this.

[lunny]

It seems govendor sync also do not copy test files?

[sapk]

Oh it seems that https://github.com/go-gitea/gitea/blob/master/vendor/vendor.json#L3 is maybe blocking test_file ...

But it shouldn't affect the command govendor status +outside +unused that should use the same config. I will have a look at it.

[sapk]

In fact there is no test_file in vendor so if this work in other dependencies this should also work here. I am searching why. https://github.com/search?utf8=%E2%9C%93&q=repo%3Ago-gitea%2Fgitea+language%3AGo+path%3Avendor+test&type=Code

[sapk]

I haven't try but https://github.com/kardianos/govendor/wiki/Govendor-CheatSheet#important-detail. I will test with fetch when I have access to a cli.

[sapk]

Ok I have tested and it seems that if you fetch it doesn't give the same checksumSHA1.

[sapk]

@lunny please do govendor fetch code.gitea.io/git and commit vendor/vendor.json

[sapk]

You should have a checksum starting with spqE5x...

[lunny]

@sapk done.

[sapk]

Perfect, I hope it will pass now ^^

[bkcsoft]

LGTM