Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases page don't show anything if git version less than 1.8 #1133

Closed
lunny opened this issue Mar 7, 2017 · 14 comments · Fixed by go-gitea/git#48 or #1614
Closed

Releases page don't show anything if git version less than 1.8 #1133

lunny opened this issue Mar 7, 2017 · 14 comments · Fixed by go-gitea/git#48 or #1614
Labels
Milestone

Comments

@lunny
Copy link
Member

lunny commented Mar 7, 2017

That means you have to upgrade your git version to more than 1.8

@lunny lunny added the type/bug label Mar 7, 2017
@lunny lunny added this to the 1.2.0 milestone Mar 7, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Apr 18, 2017

As I've mentioned in a number of issue now, go-gitea/git really needs to panic() if the git-version is below a certain value 😂

@lunny
Copy link
Member Author

lunny commented Apr 19, 2017

So I think maybe we have to ask git 1.8 to let release work.

@bkcsoft
Copy link
Member

bkcsoft commented Apr 19, 2017

@lunny I think we should have a test-suite for go-gitea/git so we can know what version we require. Guessing is never a good idea 😄

@lunny
Copy link
Member Author

lunny commented Apr 19, 2017

@bkcsoft You are right.

@strk
Copy link
Member

strk commented Dec 21, 2017

As we're now accepting 1.7 this ticket should be reopened. I just got a report about releases missing, and I'll be happy to work on making a 1.7.10 compatible version if needs be.

@strk
Copy link
Member

strk commented Dec 21, 2017

We need an automated test for the tag-extracting function in git module

@lafriks
Copy link
Member

lafriks commented Dec 21, 2017

@strk check if this returns tags in 1.7 - https://github.com/go-gitea/git/blob/master/repo_tag.go#L133

@lunny
Copy link
Member Author

lunny commented Dec 21, 2017

@strk this has been resolved by @lafriks ' syncRelease PR.

@strk
Copy link
Member

strk commented Dec 21, 2017

Where is the "syncRelease" PR ?
@lafriks tags can actually be extracted fine because I do see them in the "Code" tab, where you can select branch or tag to view...

@strk
Copy link
Member

strk commented Dec 21, 2017

I found this PR, which was already included in 1.3.2 as far as I can tell: #2459 - was that the one ? It mentions syncing on PUSH, but we're not PUSHing to that repo, is that the needed trick ?

@strk
Copy link
Member

strk commented Dec 21, 2017

I just pushed, didn't change a thing. Should I file a separate issue or will you re-open this ?

@lafriks
Copy link
Member

lafriks commented Dec 21, 2017

@strk there was migration that synced all repos. Tags are resynced on tag push/remote delete

@strk
Copy link
Member

strk commented Dec 21, 2017

the migration evidently failed. This task (sync from tags) looks really something that might benefit from having a command-line or GUI task to be run for re-synching

@strk
Copy link
Member

strk commented Dec 21, 2017

now I also tried pushing tags, which succeeded but only populated the "releases" table with 3 over 4 tags I pushed. Maybe because the 4th tag was already known by the gitea-managed repository, so was not considered new (ie: something to add a release record for). I'm now stuck. I guess I could delete the tag and re-create it, but who knows how many such cases exist in our hosting, what's really needed here is a consistency checking routine that rebuilds the missing records, not just on "push" but on manual intervention. Do you agree @lafriks ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants