Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request New Webhook: PullRequest reviewer invited / cancel invited #16321

Closed
1 of 6 tasks
lchrennew opened this issue Jul 1, 2021 · 3 comments · Fixed by #24481
Closed
1 of 6 tasks

Request New Webhook: PullRequest reviewer invited / cancel invited #16321

lchrennew opened this issue Jul 1, 2021 · 3 comments · Fixed by #24481
Assignees
@Makonike
Labels
topic/webhooks type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@lchrennew
Copy link

  • Gitea version (or commit ref): 1.14.3
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
  • Log gist:

Description

This webhook will be useful for:

  • notify reviewer
  • record pull requests' timeline

Screenshots
@noerw noerw added type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/webhooks labels Jul 1, 2021
@Makonike
Copy link
Contributor

Any plans to update?

@lunny lunny added the type/enhancement An improvement of existing functionality label Apr 29, 2023
@Makonike
Copy link
Contributor

hi, @lunny . It seems that the reviewer for this pull request also needs to trigger a webhook. I am interested in this issue, can it be assigned to me?

@lunny
Copy link
Member

lunny commented Apr 29, 2023

Thank you!!!

@Makonike Makonike mentioned this issue May 2, 2023
Merged
techknowlogick pushed a commit that referenced this issue May 25, 2023
@Makonike
New webhook trigger for receiving Pull Request review requests (#24481)
309354c 
close #16321

Provided a webhook trigger for requesting someone to review the Pull
Request.

Some modifications have been made to the returned `PullRequestPayload`
based on the GitHub webhook settings, including:
- add a description of the current reviewer object as
`RequestedReviewer` .
- setting the action to either **review_requested** or
**review_request_removed** based on the operation.
- adding the `RequestedReviewers` field to the issues_model.PullRequest.
This field will be loaded into the PullRequest through
`LoadRequestedReviewers()` when `ToAPIPullRequest` is called.

After the Pull Request is merged, I will supplement the relevant
documentation.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Makonike Makonike

Labels
topic/webhooks type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New webhook trigger for receiving Pull Request review requests
4 participants
@lunny @lchrennew @noerw @Makonike