Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Table of Contents" in CONTRIBUTING.md #1634

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Add "Table of Contents" in CONTRIBUTING.md #1634

merged 1 commit into from
Apr 28, 2017

Conversation

PeterDaveHello
Copy link
Contributor

This can help improve readability in CONTRIBUTING doc.

@sapk
Copy link
Member

sapk commented Apr 28, 2017

I would have put Introduction part before table of content since it is short. But this is maybe a personal choice and not shared with every one. For the rest LGTM.

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 28, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2017
@appleboy appleboy merged commit 18f46fd into go-gitea:master Apr 28, 2017
@lunny lunny added this to the 1.2.0 milestone Apr 28, 2017
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Apr 28, 2017
@PeterDaveHello PeterDaveHello deleted the Table-of-Contents-in-CONTRIBUTING.md branch April 28, 2017 18:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@PeterDaveHello @sapk @appleboy @lunny @tboerger